Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eigen-client-extra-features): fix eigen config test #323

Merged
merged 3 commits into from
Nov 4, 2024
Merged

fix(eigen-client-extra-features): fix eigen config test #323

merged 3 commits into from
Nov 4, 2024

Conversation

juan518munoz
Copy link

What ❔

Fix test related to EigenConfig, broken after #320

Why ❔

Make all tests pass

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

gianbelinche
gianbelinche approved these changes Nov 1, 2024
View reviewed changes
Copy link

@gianbelinche gianbelinche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juan518munoz juan518munoz merged commit aa9f1b2 into eigen-client-extra-features Nov 4, 2024
13 of 24 checks passed
@juan518munoz juan518munoz deleted the eigen-client-fix-config branch November 4, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianbelinche gianbelinche gianbelinche approved these changes

@juanbono juanbono juanbono approved these changes

Assignees
No one assigned
Labels
external-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juan518munoz @juanbono @gianbelinche