Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eigen-client-extra-features): Eigen client memstore #321

Merged
merged 16 commits into from
Nov 5, 2024
Merged

feat(eigen-client-extra-features): Eigen client memstore #321

merged 16 commits into from
Nov 5, 2024

Conversation

gianbelinche
Copy link

What ❔

This PR reimplements memstore client

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@gianbelinche gianbelinche mentioned this pull request Nov 1, 2024
Closed
12 tasks
@juan518munoz
Copy link

Having store_blob and put_blob separately seems unnecessary, maybe it would be better to just combine them.

juan518munoz
juan518munoz requested changes Nov 1, 2024
View reviewed changes
Copy link

@juan518munoz juan518munoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But let's discuss the comments briefly before merging.

Base automatically changed from eigen-client-non-auth-dispersal to eigen-client-extra-features November 1, 2024 20:45
@gianbelinche
Copy link
Author

Having store_blob and put_blob separately seems unnecessary, maybe it would be better to just combine them.

Ill remove store_blob and make it more similar to RawEigenClient

juanbono
juanbono requested changes Nov 4, 2024
View reviewed changes
Copy link
Member

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some docs to the memstore struct and important functions

@gianbelinche
Copy link
Author

Please add some docs to the memstore struct and important functions

Done

@gianbelinche gianbelinche merged commit e033630 into eigen-client-extra-features Nov 5, 2024
13 of 24 checks passed
@gianbelinche gianbelinche deleted the eigen-client-memstore branch November 5, 2024 16:10
@juanbono juanbono mentioned this pull request Nov 8, 2024
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan518munoz juan518munoz juan518munoz approved these changes

@juanbono juanbono juanbono approved these changes

Assignees
No one assigned
Labels
external-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gianbelinche @juan518munoz @juanbono