Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

[0.13] Fee-related updates #1202

Merged
merged 19 commits into from
Mar 12, 2024
Merged

[0.13] Fee-related updates #1202

merged 19 commits into from
Mar 12, 2024

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Jan 23, 2024

Changes aimed at making sir return the same fees as blockifier version 0.5.0-dev.0
Change List:

  • Use the new function get_onchain_data_cost instead of multiplying onchain_data_length by the sharp word cost when calculating fees

  • Update the values on the default OsResources to match those of blockifier 0.5.0-dev.0

The rest of the PR consists of test updates

@fmoletta fmoletta changed the base branch from main to update-check-fee-balance January 23, 2024 20:36
Base automatically changed from update-check-fee-balance to main January 30, 2024 20:17
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.00%. Comparing base (370d406) to head (9462ba3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
+ Coverage   88.97%   89.00%   +0.02%     
==========================================
  Files          52       52              
  Lines       15562    15593      +31     
==========================================
+ Hits        13847    13878      +31     
  Misses       1715     1715              
Files Coverage Δ
src/execution/gas_usage.rs 100.00% <100.00%> (ø)
src/execution/os_usage.rs 99.68% <100.00%> (+0.03%) ⬆️
src/lib.rs 98.22% <100.00%> (ø)
src/transaction/declare_deprecated.rs 91.26% <100.00%> (ø)
src/transaction/invoke_function.rs 95.82% <100.00%> (ø)
src/transaction/l1_handler.rs 90.27% <100.00%> (ø)

@fmoletta fmoletta marked this pull request as ready for review March 7, 2024 21:12
@fmoletta fmoletta added the 0.13 label Mar 7, 2024
@fmoletta fmoletta linked an issue Mar 11, 2024 that may be closed by this pull request
@fmoletta fmoletta added this pull request to the merge queue Mar 12, 2024
Merged via the queue into main with commit b756567 Mar 12, 2024
7 checks passed
@fmoletta fmoletta deleted the update-gas-calculation branch March 12, 2024 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate gas mismatch on new transactions
4 participants