This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
force-pushed
the
update-gas-calculation
branch
from
February 5, 2024 14:51
bda2e40
to
d012fe1
Compare
fmoletta
force-pushed
the
update-gas-calculation
branch
from
March 7, 2024 13:54
73bd7ee
to
9d07bfe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1202 +/- ##
==========================================
+ Coverage 88.97% 89.00% +0.02%
==========================================
Files 52 52
Lines 15562 15593 +31
==========================================
+ Hits 13847 13878 +31
Misses 1715 1715
|
edg-l
approved these changes
Mar 8, 2024
juanbono
approved these changes
Mar 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes aimed at making sir return the same fees as blockifier version 0.5.0-dev.0
Change List:
Use the new function
get_onchain_data_cost
instead of multiplyingonchain_data_length
by the sharp word cost when calculating feesUpdate the values on the default OsResources to match those of blockifier 0.5.0-dev.0
The rest of the PR consists of test updates