Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Merkle Tree CLI example #955

Merged
merged 6 commits into from
Jan 7, 2025
Merged

Update Merkle Tree CLI example #955

merged 6 commits into from
Jan 7, 2025

Conversation

jotabulacios
Copy link
Contributor

@jotabulacios jotabulacios commented Dec 30, 2024

Update docs for Merkle Tree CLI example

Description

This PR updates the generate_merkle_tree and generate_merkle_proof functions to create the root and leaf files, removing the need for manual creation.
The documentation was updated to reflect these changes

@jotabulacios jotabulacios marked this pull request as ready for review December 30, 2024 20:20
@jotabulacios jotabulacios requested a review from a team as a code owner December 30, 2024 20:20
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.32%. Comparing base (4ee0600) to head (ce1e34f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #955   +/-   ##
=======================================
  Coverage   71.32%   71.32%           
=======================================
  Files         155      155           
  Lines       33537    33537           
=======================================
  Hits        23920    23920           
  Misses       9617     9617           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ColoCarletti ColoCarletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jotabulacios jotabulacios added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 6fb54a2 Jan 7, 2025
8 checks passed
@jotabulacios jotabulacios deleted the fix_docs_merkle_tree branch January 7, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants