Baby bear extension #942
Merged
Baby bear extension #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #942 +/- ##
==========================================
+ Coverage 71.04% 71.12% +0.07%
==========================================
Files 153 153
Lines 32770 33101 +331
==========================================
+ Hits 23283 23542 +259
- Misses 9487 9559 +72 ☔ View full report in Codecov by Sentry. |
ColoCarletti
requested review from
MauroToscano,
jrchatruc,
ilitteri,
entropidelic and
pablodeymo
| <Degree4BabyBearExtensionField as IsField>::add(a, a) | ||
| } | ||
|
|
||
| fn pow<T>(a: &Self::BaseType, mut exponent: T) -> Self::BaseType |
There was a problem hiding this comment.
This can be written simpler. There are some repetitions of code
pablodeymo
reviewed
Nov 29, 2024
Comment on lines
82
to
87
| [ | ||
| FieldElement::zero(), | ||
| FieldElement::zero(), | ||
| FieldElement::zero(), | ||
| FieldElement::zero(), | ||
| ] |
There was a problem hiding this comment.
Suggested change
| [ | |
| FieldElement::zero(), | |
| FieldElement::zero(), | |
| FieldElement::zero(), | |
| FieldElement::zero(), | |
| ] | |
| Self::BaseType::default() |
pablodeymo
reviewed
Nov 29, 2024
Comment on lines
221
to
245
| impl ByteConversion for [FieldElement<Babybear31PrimeField>; 4] { | ||
| #[cfg(feature = "alloc")] | ||
| fn to_bytes_be(&self) -> alloc::vec::Vec<u8> { | ||
| unimplemented!() | ||
| } | ||
|
|
||
| #[cfg(feature = "alloc")] | ||
| fn to_bytes_le(&self) -> alloc::vec::Vec<u8> { | ||
| unimplemented!() | ||
| } | ||
|
|
||
| fn from_bytes_be(_bytes: &[u8]) -> Result<Self, crate::errors::ByteConversionError> | ||
| where | ||
| Self: Sized, | ||
| { | ||
| unimplemented!() | ||
| } | ||
|
|
||
| fn from_bytes_le(_bytes: &[u8]) -> Result<Self, crate::errors::ByteConversionError> | ||
| where | ||
| Self: Sized, | ||
| { | ||
| unimplemented!() | ||
| } | ||
| } |
There was a problem hiding this comment.
I think it's better to implement this methods before merging the PR.
pablodeymo
reviewed
Dec 11, 2024
| prop_assert_eq!(fft_eval, naive_eval); | ||
| } | ||
|
|
||
| // #[cfg(not(any(feature = "metal"),not(feature = "cuda")))] |
There was a problem hiding this comment.
if this line will be commented out, it's better to remove it
pablodeymo
approved these changes
Dec 11, 2024
diegokingston
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quartic Baby Bear Extension
Description
Add the field extension of Baby Bear of degree 4 using the irreducible polynomial x^4 + 11.
Type of change
Please delete options that are not relevant.