Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhancing loki logging capture #1310

Merged
merged 6 commits into from
Sep 30, 2024
Merged

feat: enhancing loki logging capture #1310

merged 6 commits into from
Sep 30, 2024

Conversation

rodrigo-o
Copy link
Collaborator

@rodrigo-o rodrigo-o commented Sep 27, 2024 •
edited
Loading

Motivation

This PR aims to make it easy to run the node with a specific logfile and display logs correctly on Grafana's Loki

Description

This PR handle a couple of things:

  • Added convinience make task to run the node with a predefined log file
  • Modified promtail config to add pid, slot and root to the fields in the logs
  • Created a custom formatter to follow LogfmtEx, but correctly format roots and bits as with our current ConsoleLogger
  • Renamed the ConsoleLogger for clarity and consistency to CustomConsoleLogger

@rodrigo-o rodrigo-o marked this pull request as ready for review September 27, 2024 15:10
@rodrigo-o rodrigo-o requested a review from a team as a code owner September 27, 2024 15:10
Arkenan
Arkenan approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@Arkenan Arkenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkenan Arkenan merged commit 4e5afab into main Sep 30, 2024
19 checks passed
@Arkenan Arkenan deleted the enhancing-loki-logging-capture branch September 30, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkenan Arkenan Arkenan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Lambda Ethereum Consensus Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodrigo-o @Arkenan