fix: eth1data votes error on block propose #1307
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This errors were encountered on a long running session after passing the
ChainSpec.get("SECONDS_PER_ETH1_BLOCK") * ChainSpec.get("ETH1_FOLLOW_DISTANCE")
slots threshold.Description
This PR solved 4 issues, from lower to higher priority:
has_majority?/2
calculation was not updating the votes past half of period, effectively this wasn't an issue, worst case another vote has also half of the votes totalling to the 100%, but it was pretty useful when debugging, adding it doesn't modify functionality.List.last/1
on a MapSet, this was part of some previous refactor.Resolves #1304