Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cairo 2.9.0-dev (native v0.2.2-alpha.0 branch) #877

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Conversation

edg-l
Copy link
Collaborator

@edg-l edg-l commented Oct 23, 2024

This release is done for upstreams convenience, this pr doesn't need to be merged, but a tag will be made and released to crates

Fixes #879

This is cairo-native with cairo 2.9.0 features, and fixes from main as of 16715e5

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

* implement get_class_hash_at syscall

* fix
Copy link

github-actions bot commented Oct 24, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.207 ± 0.259 10.672 11.413 8.27 ± 0.19
cairo-native (embedded AOT) 3.416 ± 0.029 3.370 3.473 2.52 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 3.194 ± 0.011 3.181 3.210 2.36 ± 0.01
cairo-native (standalone AOT with -march=native) 1.355 ± 0.002 1.353 1.357 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.708 ± 0.289 10.450 11.285 131.97 ± 3.57
cairo-native (embedded AOT) 3.020 ± 0.041 2.964 3.088 37.22 ± 0.52
cairo-native (embedded JIT using LLVM's ORC Engine) 2.744 ± 0.018 2.715 2.768 33.82 ± 0.23
cairo-native (standalone AOT with -march=native) 0.081 ± 0.000 0.081 0.081 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.297 ± 0.030 4.266 4.364 17.71 ± 0.12
cairo-native (embedded AOT) 3.171 ± 0.040 3.108 3.239 13.07 ± 0.17
cairo-native (embedded JIT using LLVM's ORC Engine) 3.076 ± 0.030 3.029 3.132 12.68 ± 0.12
cairo-native (standalone AOT with -march=native) 0.243 ± 0.000 0.242 0.243 1.00

@edg-l edg-l marked this pull request as ready for review October 24, 2024 14:19
@edg-l edg-l changed the title update to cairo 2.9.0-dev cairo 2.9.0-dev (native v0.2.2-alpha.0 branch) Nov 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 33.42618% with 239 lines in your changes missing coverage. Please review.

Project coverage is 82.41%. Comparing base (16715e5) to head (0bc6f40).

Files with missing lines Patch % Lines
src/libfuncs/starknet.rs 0.00% 131 Missing ⚠️
src/libfuncs/int_range.rs 61.76% 39 Missing ⚠️
src/starknet.rs 4.16% 23 Missing ⚠️
src/values.rs 52.27% 21 Missing ⚠️
src/bin/cairo-native-test.rs 0.00% 9 Missing ⚠️
src/starknet_stub.rs 0.00% 7 Missing ⚠️
src/debug.rs 0.00% 4 Missing ⚠️
src/types.rs 81.25% 3 Missing ⚠️
src/bin/utils/mod.rs 0.00% 1 Missing ⚠️
src/executor.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
- Coverage   82.91%   82.41%   -0.51%     
==========================================
  Files         120      122       +2     
  Lines       34362    34704     +342     
==========================================
+ Hits        28490    28600     +110     
- Misses       5872     6104     +232     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.9.0] Implement int_range_try_new and int_range_pop_front libfuncs
3 participants