Skip to content

Add blockifier tests to the ci #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 35 commits into
base: main
Choose a base branch
from
Draft

Conversation

FrancoGiachetta
Copy link
Contributor

We've recently had an issue when running blockifier's tests with native. This PR adds those to the ci so as to have that checked (Only for linux).

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Apr 11, 2025

Benchmark results Main vs HEAD.

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 5.081 ± 0.025 5.046 5.133 1.00
base dict_insert.cairo (AOT) 5.145 ± 0.165 5.006 5.501 1.01 ± 0.03

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_insert.cairo (JIT) 5.066 ± 0.031 5.015 5.110 1.02 ± 0.01
head dict_insert.cairo (AOT) 4.991 ± 0.053 4.939 5.107 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 5.170 ± 0.088 5.030 5.276 1.05 ± 0.02
base dict_snapshot.cairo (AOT) 4.926 ± 0.057 4.852 5.064 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_snapshot.cairo (JIT) 5.008 ± 0.045 4.933 5.074 1.03 ± 0.01
head dict_snapshot.cairo (AOT) 4.839 ± 0.032 4.796 4.897 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 5.437 ± 0.080 5.329 5.549 1.00 ± 0.02
base factorial_2M.cairo (AOT) 5.414 ± 0.085 5.308 5.566 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 5.293 ± 0.029 5.257 5.346 1.00
head factorial_2M.cairo (AOT) 5.297 ± 0.048 5.239 5.401 1.00 ± 0.01

Base

Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 4.908 ± 0.032 4.855 4.957 1.01 ± 0.01
base fib_2M.cairo (AOT) 4.864 ± 0.045 4.805 4.940 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 4.868 ± 0.031 4.800 4.907 1.01 ± 0.01
head fib_2M.cairo (AOT) 4.805 ± 0.035 4.760 4.871 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 5.116 ± 0.051 5.070 5.234 1.03 ± 0.01
base linear_search.cairo (AOT) 4.944 ± 0.024 4.908 4.986 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head linear_search.cairo (JIT) 5.247 ± 0.179 5.012 5.539 1.05 ± 0.04
head linear_search.cairo (AOT) 4.999 ± 0.118 4.887 5.187 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 5.161 ± 0.026 5.103 5.204 1.03 ± 0.01
base logistic_map.cairo (AOT) 5.002 ± 0.019 4.970 5.040 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 5.562 ± 0.168 5.249 5.835 1.11 ± 0.03
head logistic_map.cairo (AOT) 5.014 ± 0.028 4.964 5.054 1.00

Copy link

github-actions bot commented Apr 11, 2025

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.461 ± 0.191 11.321 11.939 2.30 ± 0.04
cairo-native (embedded AOT) 4.980 ± 0.029 4.928 5.011 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 5.072 ± 0.035 5.019 5.131 1.02 ± 0.01

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 852.0 ± 6.9 841.5 863.5 1.00
cairo-native (embedded AOT) 5114.9 ± 33.0 5057.1 5175.2 6.00 ± 0.06
cairo-native (embedded JIT using LLVM's ORC Engine) 5134.8 ± 79.8 4996.5 5238.1 6.03 ± 0.11

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.262 ± 0.014 5.241 5.287 1.00
cairo-native (embedded AOT) 5.297 ± 0.033 5.254 5.362 1.01 ± 0.01
cairo-native (embedded JIT using LLVM's ORC Engine) 5.351 ± 0.020 5.323 5.378 1.02 ± 0.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.059 ± 0.010 5.036 5.069 1.05 ± 0.01
cairo-native (embedded AOT) 4.807 ± 0.045 4.736 4.863 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 4.891 ± 0.036 4.820 4.955 1.02 ± 0.01

Benchmark for program linear_search

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 835.4 ± 9.8 818.0 852.6 1.00
cairo-native (embedded AOT) 5144.8 ± 89.4 5000.7 5253.8 6.16 ± 0.13
cairo-native (embedded JIT using LLVM's ORC Engine) 5344.7 ± 23.1 5313.1 5376.9 6.40 ± 0.08

Benchmark for program logistic_map

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 531.1 ± 5.7 524.4 542.9 1.00
cairo-native (embedded AOT) 4955.0 ± 29.3 4905.7 4995.7 9.33 ± 0.11
cairo-native (embedded JIT using LLVM's ORC Engine) 5198.3 ± 63.9 5137.6 5356.9 9.79 ± 0.16

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.48%. Comparing base (0ae244c) to head (3fd54b7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1176   +/-   ##
=======================================
  Coverage   80.48%   80.48%           
=======================================
  Files         110      110           
  Lines       29580    29580           
=======================================
  Hits        23807    23807           
  Misses       5773     5773           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines 344 to 392

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it is an error from the diff. If you check the file, is it identical as how it is currently in main

@JulianGCalderon JulianGCalderon marked this pull request as draft May 5, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants