-
Notifications
You must be signed in to change notification settings - Fork 47
Add blockifier tests to the ci #1176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Benchmark results Main vs HEAD.Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
|
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.461 ± 0.191 | 11.321 | 11.939 | 2.30 ± 0.04 |
cairo-native (embedded AOT) |
4.980 ± 0.029 | 4.928 | 5.011 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5.072 ± 0.035 | 5.019 | 5.131 | 1.02 ± 0.01 |
Benchmark for program dict_snapshot
Open benchmarks
Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
852.0 ± 6.9 | 841.5 | 863.5 | 1.00 |
cairo-native (embedded AOT) |
5114.9 ± 33.0 | 5057.1 | 5175.2 | 6.00 ± 0.06 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5134.8 ± 79.8 | 4996.5 | 5238.1 | 6.03 ± 0.11 |
Benchmark for program factorial_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.262 ± 0.014 | 5.241 | 5.287 | 1.00 |
cairo-native (embedded AOT) |
5.297 ± 0.033 | 5.254 | 5.362 | 1.01 ± 0.01 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5.351 ± 0.020 | 5.323 | 5.378 | 1.02 ± 0.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.059 ± 0.010 | 5.036 | 5.069 | 1.05 ± 0.01 |
cairo-native (embedded AOT) |
4.807 ± 0.045 | 4.736 | 4.863 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
4.891 ± 0.036 | 4.820 | 4.955 | 1.02 ± 0.01 |
Benchmark for program linear_search
Open benchmarks
Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
835.4 ± 9.8 | 818.0 | 852.6 | 1.00 |
cairo-native (embedded AOT) |
5144.8 ± 89.4 | 5000.7 | 5253.8 | 6.16 ± 0.13 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5344.7 ± 23.1 | 5313.1 | 5376.9 | 6.40 ± 0.08 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
531.1 ± 5.7 | 524.4 | 542.9 | 1.00 |
cairo-native (embedded AOT) |
4955.0 ± 29.3 | 4905.7 | 4995.7 | 9.33 ± 0.11 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5198.3 ± 63.9 | 5137.6 | 5356.9 | 9.79 ± 0.16 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
=======================================
Coverage 80.48% 80.48%
=======================================
Files 110 110
Lines 29580 29580
=======================================
Hits 23807 23807
Misses 5773 5773 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ative into add-blockifier-tests
97f2d59
to
ebfdc99
Compare
.github/workflows/ci.yml
Outdated
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it is an error from the diff. If you check the file, is it identical as how it is currently in main
We've recently had an issue when running blockifier's tests with native. This PR adds those to the ci so as to have that checked (Only for linux).
Checklist