Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writing of trace file #37

Merged
merged 38 commits into from
Aug 4, 2023
Merged

Writing of trace file #37

merged 38 commits into from
Aug 4, 2023

Conversation

gabrielbosio
Copy link
Collaborator

@gabrielbosio gabrielbosio commented Aug 2, 2023 •
edited
Loading

No description provided.

@gabrielbosio
Add segments relocation
69c93b1
@gabrielbosio
Add segment relocation tests
4ec1c0c
@gabrielbosio
Normalize name convention
8661157
@gabrielbosio
Add and fix segments test
1f4bcb0
@gabrielbosio
Add missing memory methods
13f806f
@gabrielbosio
Add memory relocation
119d47d
@gabrielbosio
Merge branch 'main' into memory_relocation
8b446b0
@gabrielbosio
Improve get methods
0a90b93
@gabrielbosio
Move cairo runner to runners package
551fd09
@gabrielbosio
Remove unnecessary getters
4a0f451
@gabrielbosio
Merge branch 'main' into memory_relocation
7e79671
@gabrielbosio
Remove check for existing segment size
a5a571f
@gabrielbosio
Avoid passing relocation table as a copy
f17c2b4
@gabrielbosio
Fix memory relocation fn usage
3ad79d4
@gabrielbosio
Move memory relocation fn
e3565a7
@gabrielbosio
Recover memory relocation test
3de475e
@gabrielbosio
Make relocated memory a map
391aa3e
@gabrielbosio
Merge branch 'main' into memory_relocation
69ccfa9
@gabrielbosio
Remove sorted keys generation
5143818
@gabrielbosio
Remove zero fill in size computation
d51c4f4
@gabrielbosio
Document value relocation fn
a36e574
@gabrielbosio
Remove unused index var
86e1ed2
@gabrielbosio
Remove zero initialization of vm fields
a35342b
@gabrielbosio
Add trace relocation
c7028a3
@gabrielbosio
Improve trace relocation test
3df90e5
@gabrielbosio
Add fn to write trace files
987e123
fmoletta
fmoletta reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the cairo_trace_struct file the fibonacci.cairo's trace file generated by the cairo vm? If so, can we rename it to fibonacci.trace to avoid confusions?

@gabrielbosio
Copy link
Collaborator Author

Is the cairo_trace_struct file the fibonacci.cairo's trace file generated by the cairo vm? If so, can we rename it to fibonacci.trace to avoid confusions?

It's the trace file used to test the writing of the trace file in the cairo VM repo.. It's the trace generated from struct.json.

@gabrielbosio gabrielbosio marked this pull request as ready for review August 2, 2023 20:50
@fmoletta
Copy link
Contributor

fmoletta commented Aug 2, 2023

Is the cairo_trace_struct file the fibonacci.cairo's trace file generated by the cairo vm? If so, can we rename it to fibonacci.trace to avoid confusions?

It's the trace file used to test the writing of the trace file in the cairo VM repo.. It's the trace generated from struct.json.

In that case I think we should add the files struct.cairo, struct.json and struct.trace, this way we can identify where they come from and easily replace them once we set up memory and trace comparison with cairo-vm

fmoletta
fmoletta reviewed Aug 2, 2023
View reviewed changes
pkg/vm/vm_core.go Outdated Show resolved Hide resolved
fmoletta
fmoletta reviewed Aug 3, 2023
View reviewed changes
pkg/vm/trace.go Outdated Show resolved Hide resolved
fmoletta
fmoletta reviewed Aug 3, 2023
View reviewed changes
pkg/vm/vm_core.go Outdated Show resolved Hide resolved
fmoletta
fmoletta approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jrchatruc jrchatruc merged commit 5e060f8 into main Aug 4, 2023
1 check passed
@jrchatruc jrchatruc deleted the trace_file branch August 4, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmoletta fmoletta fmoletta approved these changes

@jrchatruc jrchatruc jrchatruc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielbosio @fmoletta @jrchatruc