Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor error messages to lowercase and fix typos #320

Closed
wants to merge 2 commits into from
Closed

Refactor error messages to lowercase and fix typos #320

wants to merge 2 commits into from

Conversation

Jesserc
Copy link

@Jesserc Jesserc commented Nov 11, 2023

Updated error messages to lowercase and fixed typos in code.

  • Changed error messages to start with lowercase for better style (as per go-staticcheck ST1005).
  • Fixed typos.

This makes the code easier to read and follows Go's best practices.

Affected file(s):

  • All files in pkg/vm/memory/

Test result:
image

Copy link
Author

@Jesserc Jesserc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you guys think

@fmoletta

Copy link
Contributor

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e01d7a5) 57.48% compared to head (a97ec5d) 57.48%.

Files Patch % Lines
pkg/vm/memory/relocatable.go 60.00% 2 Missing ⚠️
pkg/vm/memory/memory.go 66.66% 0 Missing and 1 partial ⚠️
pkg/vm/memory/relocatable_err.go 0.00% 1 Missing ⚠️
pkg/vm/memory/segments.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #320   +/-   ##
=======================================
  Coverage   57.48%   57.48%           
=======================================
  Files          55       55           
  Lines        7145     7145           
=======================================
  Hits         4107     4107           
  Misses       2625     2625           
  Partials      413      413           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jesserc Jesserc closed this Jan 23, 2024
@Jesserc Jesserc deleted the error-formatting-fixes branch January 23, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants