Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: constants for opcodes #318

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

greged93
Copy link
Contributor

@greged93 greged93 commented Oct 14, 2023

Fixes the values of the constants for the opcodes based on the Cairo paper.

@codecov-commenter
Copy link

Codecov Report

Merging #318 (ebc719e) into main (e5fcc25) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   56.37%   56.37%           
=======================================
  Files          50       50           
  Lines        6634     6634           
=======================================
  Hits         3740     3740           
  Misses       2506     2506           
  Partials      388      388           
Files Coverage Δ
pkg/vm/instruction.go 97.85% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The values of the constants themselves aren't used so this change shouldn't have an impact on the vm's behaviour.
Nevertheless the change does make the code a bit more consistent (given the switch at line 207 )

@Oppen Oppen added this pull request to the merge queue Oct 17, 2023
Merged via the queue into lambdaclass:main with commit 5c151ff Oct 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants