Implement Blake2s Hints (Part 1) #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pefontana
approved these changes
Oct 5, 2023
juanbono
approved these changes
Oct 23, 2023
Codecov Report
@@ Coverage Diff @@
## main #311 +/- ##
==========================================
+ Coverage 57.07% 57.24% +0.16%
==========================================
Files 52 53 +1
Lines 6915 6984 +69
==========================================
+ Hits 3947 3998 +51
- Misses 2574 2586 +12
- Partials 394 400 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
reviewed
Oct 24, 2023
Comment on lines
+430
to
+451
| func TestToU321(t *testing.T) { | ||
| felt := lambdaworks.FeltOne() | ||
| result, err := felt.ToU32() | ||
|
|
||
| var expected uint32 = 1 | ||
|
|
||
| if expected != result { | ||
| t.Errorf("Error in conversion expected: %v, got %v with err: %v", expected, result, err) | ||
| } | ||
|
|
||
| } | ||
|
|
||
| func TestToU3210230(t *testing.T) { | ||
| felt := lambdaworks.FeltFromUint64(10230) | ||
| result, err := felt.ToU32() | ||
|
|
||
| var expected uint32 = 10230 | ||
|
|
||
| if expected != result { | ||
| t.Errorf("Error in conversion expected: %v, got %v with err: %v", expected, result, err) | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe separate the the number from the type in the name with an underscore, or put the number first, so it's easier to read as two separate entities.
Oppen
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #310