Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RunUntilPc & GetReturnValues #302

Merged
merged 10 commits into from
Sep 29, 2023
Merged

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Sep 27, 2023

Depends on #301 & #300

@fmoletta fmoletta changed the base branch from main to GenWriteArg September 27, 2023 20:57
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Merging #302 (b7684cd) into execution-resources (4538465) will increase coverage by 0.11%.
The diff coverage is 65.62%.

@@                   Coverage Diff                   @@
##           execution-resources     #302      +/-   ##
=======================================================
+ Coverage                56.37%   56.48%   +0.11%     
=======================================================
  Files                       47       47              
  Lines                     6012     6069      +57     
=======================================================
+ Hits                      3389     3428      +39     
- Misses                    2294     2303       +9     
- Partials                   329      338       +9     
Files Coverage Δ
pkg/vm/vm_core.go 44.08% <50.00%> (+0.07%) ⬆️
pkg/vm/memory/segments.go 77.03% <84.00%> (+1.58%) ⬆️
pkg/runners/cairo_runner.go 46.95% <54.54%> (-0.29%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fmoletta fmoletta changed the base branch from GenWriteArg to execution-resources September 27, 2023 20:58
@fmoletta fmoletta marked this pull request as ready for review September 27, 2023 20:59
@pefontana pefontana merged commit 3802a3e into execution-resources Sep 29, 2023
2 checks passed
@pefontana pefontana deleted the runFromEntrypoint branch September 29, 2023 17:57
github-merge-queue bot pushed a commit that referenced this pull request Sep 29, 2023
… as an argument (#300)

* Add ExecutionResources struct

* Fix: Remove vm argument from CairoRunner methods

* Finish func + remove todos

* Add unit test

* Add `RunUntilPc` & `GetReturnValues` (#302)

* Implement GenArg

* Remove recursive processing

* Add unit tests

* Fix test values

* Start fn

* Add RunFromEntryPoint

* Add test for RunFromEntryPoint

* Add unit tests

* Add comments

---------

Co-authored-by: Pedro Fontana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants