Execution #15
Merged
Execution #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
* Add roadmap to README (#17) * Add roadmap to README * Small typo * Add felt documentation (#16) * Add Basic Types + Memory walkthrough to Write your own Cairo VM section (#8) * Add non c-specific project guidelines * Copy the rest of the file * Copy + adapt introduction * Copy doc in C repo PR * Replace relocatable structure with go structure * Make Relocatable fields public * Update MaybeRelocatable section with go version * Remove leftover comment * Update Memory structure * Add Insert code (minus temp segments comment) * Add Get code (minus temp segments comment) * Add MemorySegmentManager section * Add maybeRelocatable convenience methods * Add missing language keyword * Fix typo * fmt * Replace hashmap for map * Add `RunContext` & `VirtualMachine` structres to Write your own VM section (#12) * Add RunContext * Add VM structure * First draft OpcodeAssertions * First draft OpcodeAssertions * Testing * TestOpcodeAssertionsResUnconstrained * Testing * Mini improvment in README (#34) Co-authored-by: Pablo Deymonnaz <[email protected]> * Review PR #1 - Removes useless methods - Formats variables name - Removes useless pointers * Review PR #1 - Removes useless methods - Formats variables name - Removes useless pointers - Deletes again mock function - Rename function names * Removed error difference. --------- Co-authored-by: Javier Rodríguez Chatruc <[email protected]> Co-authored-by: fmoletta <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: Pablo Deymonnaz <[email protected]>
fmoletta
reviewed
Aug 3, 2023
fmoletta
reviewed
Aug 3, 2023
fmoletta
reviewed
Aug 3, 2023
fmoletta
reviewed
Aug 3, 2023
fmoletta
reviewed
Aug 3, 2023
fmoletta
reviewed
Aug 3, 2023
fmoletta
reviewed
Aug 3, 2023
fmoletta
reviewed
Aug 3, 2023
There was a problem hiding this comment.
Deductions are missing in the VirtualMachine.ComputeOperands method. We can ignore the builtin's deductions for now, but the methods deduce_op0, deduce_op and deduce_dst are part of the core execution process. We can add them in a separate PR if its too much code, but please add some TODO's in their place, and a comment on top of computeOperands stating that its not complete/operational till it is addressed
fmoletta
reviewed
Aug 3, 2023
fmoletta
reviewed
Aug 4, 2023
fmoletta
reviewed
Aug 4, 2023
fmoletta
reviewed
Aug 4, 2023
fmoletta
reviewed
Aug 4, 2023
fmoletta
reviewed
Aug 4, 2023
fmoletta
reviewed
Aug 4, 2023
fmoletta
reviewed
Aug 4, 2023
fmoletta
reviewed
Aug 4, 2023
fmoletta
reviewed
Aug 4, 2023
Co-authored-by: fmoletta <[email protected]>
Co-authored-by: fmoletta <[email protected]>
Co-authored-by: fmoletta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request adds the logic of compute_operands function, besides several other functions for manipulation of maybe relocatable and relocatable