Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lambdaworks wrapper #13

Merged
merged 27 commits into from
Aug 3, 2023
Merged

Lambdaworks wrapper #13

merged 27 commits into from
Aug 3, 2023

Conversation

toni-calvin
Copy link
Contributor

No description provided.

@toni-calvin toni-calvin marked this pull request as ready for review July 31, 2023 17:01
mmsc2
mmsc2 approved these changes Jul 31, 2023
View reviewed changes
pkg/lambdaworks/lambdaworks.go Outdated Show resolved Hide resolved
fmoletta
fmoletta reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!
I think we should add a FromHex method, as with this api we can only create a Felt from uint64

@mmsc2
Copy link
Contributor

mmsc2 commented Jul 31, 2023

Looks Good! I think we should add a FromHex method, as with this api we can only create a Felt from uint64

In addition to this. a method "from string" would be really useful too.

@gabrielbosio gabrielbosio mentioned this pull request Jul 31, 2023
Merged
toni-calvin and others added 2 commits August 3, 2023 10:30
@toni-calvin
Remove useless method.
1bef004
@toni-calvin @fmoletta
Update pkg/lambdaworks/lambdaworks.go
796bfc6 
More expressive method name.

Co-authored-by: fmoletta <[email protected]>
toni-calvin and others added 5 commits August 3, 2023 10:34
@toni-calvin @fmoletta
Update pkg/lambdaworks/lambdaworks.go
9a75f19 
Co-authored-by: fmoletta <[email protected]>
@toni-calvin
Merge branch 'lambdaworks-wrapper' of github.com:lambdaclass/cairo_vm…
f824c50 
….go into lambdaworks-wrapper
@toni-calvin
Added add felts method
3ff29ab 
- Felt function to add multiple felts at the same time.
@toni-calvin
Added sub felts method
5f688e1 
- Felt function to sub multiple felts at the same time.
@toni-calvin
fmt
f3a8152
fmoletta
fmoletta approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@fmoletta fmoletta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀 , left small suggestion

pkg/lambdaworks/lambdaworks.go Outdated Show resolved Hide resolved
@jrchatruc jrchatruc merged commit 9117ffd into main Aug 3, 2023
1 check passed
@jrchatruc jrchatruc deleted the lambdaworks-wrapper branch August 3, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmoletta fmoletta fmoletta approved these changes

@mmsc2 mmsc2 mmsc2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@toni-calvin @mmsc2 @fmoletta @jrchatruc