refactor: remove duplicate function get_val #1800
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmalatrax
requested review from
igaray,
Oppen,
fmoletta,
juanbono and
pefontana
as code owners
zmalatrax
force-pushed
the
refactor/remove-duplicate-fn-get_val
branch
from
57b4822
to
0ec47da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicate function
get_valfrom Cairo1HintProcessorDescription
The function
get_valis a duplicate ofres_operand_get_val, both only used in theCairo1HintProcessorto fetch values from hint parameters.get_valis only used in the hintsu256_inv_mod_nanduint256_div_modand should be replaced byres_operand_get_val.