Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Archon (Arcsi UI) endpoints #188

Merged
merged 9 commits into from
Mar 28, 2024
Merged

Refactor Archon (Arcsi UI) endpoints #188

merged 9 commits into from
Mar 28, 2024

Conversation

tuz666
Copy link
Collaborator

@tuz666 tuz666 commented Mar 26, 2024

Massive performance boost for Archon (Arcsi UI) pages.

  • I did a refactor for the view/router endpoints:
    • Previously we called the api/arcsi endpoints inside these endpoints, which as we saw put some additional, not properly handled load on the gunicorn workers
    • I refactored these endpoints to call the exact api/arcsi functions from the code instead of calling the exposed endpoints
    • These resulted a significantly faster response for Archon show and episode subpages, and a slightly faster response for the big, 'Shows archive' and 'Items archive' pages.
    • I also had to align the flask-security related decorators, for the directly used api/arcsi endpoints/functions

I had to align the CI tests as well.

Small fix in entrypoint.sh for the cron job to properly start when the app container is created, this was required for tmpreaper usage.

GitHub Actions recommended to upgrade the Node version from 16 to 20.

PR was tested locally and it is also deployed currently on the dev env.
It seems like there is no frontend compatibility issues either.

@tuz666 tuz666 marked this pull request as ready for review March 27, 2024 10:53
@tuz666 tuz666 requested review from pvj and gammaw March 27, 2024 10:55
Copy link
Member

@gammaw gammaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big kudo! That was much needed and it results in a much cleaner code. Look good and logical!

@tuz666 tuz666 merged commit 5b4a7bc into master Mar 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants