-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Archon (Arcsi UI) endpoints #188
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gammaw
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big kudo! That was much needed and it results in a much cleaner code. Look good and logical!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Massive performance boost for Archon (Arcsi UI) pages.
view
/router
endpoints:api
/arcsi
endpoints inside these endpoints, which as we saw put some additional, not properly handled load on the gunicorn workersapi
/arcsi
functions from the code instead of calling the exposed endpointsapi
/arcsi
endpoints/functionsI had to align the CI tests as well.
Small fix in
entrypoint.sh
for the cron job to properly start when the app container is created, this was required for tmpreaper usage.GitHub Actions recommended to upgrade the Node version from 16 to 20.
PR was tested locally and it is also deployed currently on the dev env.
It seems like there is no frontend compatibility issues either.