Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added /var/log/sanlock.log to the log collection from hosts #290

Merged
merged 2 commits into from
Jul 18, 2016

Conversation

mykaul
Copy link

@mykaul mykaul commented Jul 18, 2016

Take 2 of trying to add /var/log/sanlock.log to the log collection our the VDSM hosts.

@david-caro
Copy link
Member

hmmm... it says you have to rebase :/

@mykaul
Copy link
Author

mykaul commented Jul 18, 2016

Tried with the 'Update' button... Let's see how that works.

@david-caro
Copy link
Member

That adds a dummy 'merge' commit to the branch, that when merged again to master, is followed by yet another merge commit...

@mykaul
Copy link
Author

mykaul commented Jul 18, 2016

@david-caro - so should I merge or not this one?

@david-caro
Copy link
Member

Yes, but use the ci process of sending the message to jenkins, so it does the build+test+release pipeline fully:
http://lago.readthedocs.io/en/stable/CI.html#getting-the-pull-request-merged

@mykaul
Copy link
Author

mykaul commented Jul 18, 2016

ci test please

@mykaul
Copy link
Author

mykaul commented Jul 18, 2016

ci merge please

1 similar comment
@mykaul
Copy link
Author

mykaul commented Jul 18, 2016

ci merge please

@lago-bot lago-bot merged commit 14d884c into lago-project:master Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants