Skip to content

Commit

Permalink
fix(visualization): Fix incorrect restriction on legend segment count
Browse files Browse the repository at this point in the history
  • Loading branch information
chriswmackey authored and Chris Mackey committed Jul 3, 2024
1 parent 0125599 commit 8a18c7e
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 6 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ jobs:
with:
python-version: 3.7
- name: set up node # we need node for for semantic release
uses: actions/setup-node@v2.1.2
uses: actions/setup-node@v4
with:
node-version: 14.2.0
node-version: 22.2.0
- name: install python dependencies
run: |
python -m pip install --upgrade pip
Expand All @@ -57,8 +57,8 @@ jobs:
- name: run semantic release
id: new_release
run: |
nextRelease="`npx semantic-release@^17.0.0 --dryRun | grep -oP 'Published release \K.*? ' || true`"
npx semantic-release@^17.0.0
nextRelease="`npx semantic-release@^23.1.1 --dryRun | grep -oP 'Published release \K.*? ' || true`"
npx semantic-release@^23.1.1
echo "::set-output name=tag::$nextRelease"
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
2 changes: 2 additions & 0 deletions .releaserc.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
[
"@semantic-release/github",
{
"successComment": false,
"failTitle": false,
"assets": [
{
"path": "docs/model.json",
Expand Down
7 changes: 7 additions & 0 deletions MANIFEST.in
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
recursive-exclude tests *
recursive-exclude docs *
recursive-exclude samples *
recursive-exclude .github *
exclude .gitignore
exclude .releaserc.json
exclude deploy.sh
4 changes: 2 additions & 2 deletions ladybug_display_schema/visualization.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,13 +138,13 @@ class LegendParameters(NoExtraBaseModel):
'maximum of the values associated with the legend will be used.'
)

segment_count: Union[Default, conint(ge=2)] = Field(
segment_count: Union[Default, conint(ge=1)] = Field(
Default(),
description='An integer representing the number of steps between '
'the high and low boundary of the legend. The default is set to 11 '
'or it will be equal to the number of items in the ordinal_dictionary. '
'Any custom values input in here should always be greater than or '
'equal to 2.'
'equal to 1.'
)

colors: List[Color] = Field(
Expand Down
2 changes: 2 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@
url="https://github.com/ladybug-tools/ladybug-display-schema",
packages=setuptools.find_packages(exclude=["tests", "scripts", "samples"]),
install_requires=requirements,
include_package_data=True,
classifiers=[
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: Implementation :: CPython",
"Operating System :: OS Independent"
],
Expand Down

0 comments on commit 8a18c7e

Please sign in to comment.