Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LA CTF Mini section to the website #93

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

asdiml
Copy link
Contributor

@asdiml asdiml commented Jan 29, 2025

As described in the title

Was unable to achieve some of the styling illustrated on the Figma but wanted to deploy a functional section

@asdiml asdiml requested review from burturt and Arc-blroth January 29, 2025 22:53
Copy link
Collaborator

@Arc-blroth Arc-blroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The meat of the styling looks good, but I do think there's a bit too much padding on the bottom
Using min-height: 100vh and padding: 10vh 0 20vh 0 looks better but please adjust to taste :D

Copy link

cloudflare-workers-and-pages bot commented Jan 30, 2025

Deploying lactf-website-new with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ac2041
Status: ✅  Deploy successful!
Preview URL: https://ade73591.lactf-website-new.pages.dev
Branch Preview URL: https://add-lactf-mini.lactf-website-new.pages.dev

View logs

@asdiml
Copy link
Contributor Author

asdiml commented Jan 30, 2025

The meat of the styling looks good, but I do think there's a bit too much padding on the bottom Using min-height: 100vh and padding: 10vh 0 20vh 0 looks better but please adjust to taste :D

Slight changes to padding and justify-content of the LA CTF Mini flexbox

@asdiml asdiml requested a review from Arc-blroth January 30, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants