Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RAIN-91113): Add glacier permission for tags call #85

Merged
merged 2 commits into from
Dec 13, 2023
Merged

feat(RAIN-91113): Add glacier permission for tags call #85

merged 2 commits into from
Dec 13, 2023

Conversation

jjzhangjjzhang
Copy link
Contributor

@jjzhangjjzhang jjzhangjjzhang commented Nov 14, 2023 •
edited
Loading

Summary

We are missing permission for tags call

How did you test this change?

Trigger collection in dev8, and verify that the tag shows up.
Verified with the follwoing query.


use schema AWS_CFG_INTERNAL;
select distinct resource_tags from aws_cfg_internal.config_details_t where service ='glacier' 
and PROPS:isSummaryRow = false

Issue

https://lacework.atlassian.net/browse/RAIN-91113

@jjzhangjjzhang jjzhangjjzhang changed the title Add glacier permission feat(RAIN-91113): Add glacier permission for tags call Nov 17, 2023
@jjzhangjjzhang jjzhangjjzhang marked this pull request as ready for review November 17, 2023 07:08
afiune
afiune approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that this change was tested.

@jjzhangjjzhang jjzhangjjzhang merged commit 6c4c163 into main Dec 13, 2023
1 check passed
@jjzhangjjzhang jjzhangjjzhang deleted the glacierPermission branch December 13, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afiune afiune afiune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjzhangjjzhang @afiune