-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RAIN-94239): Rm modify terraform to add a policy #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding permission for FIS and codeartifact Adding tag call permissions for ses,backup,amp
Added explanation to the README file as well
Adding permission for compute optimizer
(Audit Mode) Lacework IAC found 7 new violations |
jjzhangjjzhang
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me
leijin-lw
approved these changes
Jan 30, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AWS iam policy can only have up to 6144 chars. We need another policy to maintain the new services' permissions.
Modified terraform to have 2 policies created and attach to the same role.
Added permission for FIS, codeartifact.
Added tag call permission for SES, backup and AMP
Adding permission for compute-optimizer, and kinesisvideos
How did you test this change?
Tested in DEV integration.
https://docs.google.com/document/d/1rkfXAQUaA32_IShki6mTmf2aZF4HRiMSGX6_-I4pf8w/[email protected]&sharingaction=manageaccess&role=writer&tab=t.0
Issue
https://lacework.atlassian.net/browse/RAIN-94239