Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RAIN-94239): Rm modify terraform to add a policy #127

Merged
merged 10 commits into from
Jan 30, 2025

Conversation

LMAX-iwnf
Copy link
Contributor

@LMAX-iwnf LMAX-iwnf commented Jan 22, 2025

Summary

AWS iam policy can only have up to 6144 chars. We need another policy to maintain the new services' permissions.
Modified terraform to have 2 policies created and attach to the same role.
Added permission for FIS, codeartifact.
Added tag call permission for SES, backup and AMP
Adding permission for compute-optimizer, and kinesisvideos

How did you test this change?

Tested in DEV integration.
https://docs.google.com/document/d/1rkfXAQUaA32_IShki6mTmf2aZF4HRiMSGX6_-I4pf8w/[email protected]&sharingaction=manageaccess&role=writer&tab=t.0

Issue

https://lacework.atlassian.net/browse/RAIN-94239

Adding permission for FIS and codeartifact
Adding tag call permissions for ses,backup,amp
main.tf Outdated Show resolved Hide resolved
Added explanation to the README file as well
Adding permission for compute optimizer
main.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@jjzhangjjzhang jjzhangjjzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me

@LMAX-iwnf LMAX-iwnf merged commit 664dfaa into main Jan 30, 2025
11 checks passed
@LMAX-iwnf LMAX-iwnf deleted the rm_modify_terraform_to_add_a_policy branch January 30, 2025 22:48
@lacework-releng lacework-releng mentioned this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants