feat(http_session): add opt. requests timeout parameter #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can now specify after how much time a request should timeout. This new parameter will prevent the default "hang forever" behaviour request has.
pballandras
commented
Sep 18, 2023
| @@ -20,6 +20,7 @@ | |||
| from laceworksdk.exceptions import ApiError, MalformedResponse, RateLimitError | |||
|
|
|||
| logger = logging.getLogger(__name__) | |||
| HTTP_REQUEST_DEFAULT_TIMEOUT_SEC = 30 | |||
There was a problem hiding this comment.
If you feel like this is too short, feel free to ask me to change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now specify after how much time a request should timeout. This new parameter prevents the default "hang forever" behaviour
requestshas.The idea here is that if the user feels like it's taking to long, they can change strategy or fail faster.
This comes from a problem we faced using the Lacework
python-sdkwhere a request took 8 minutes to finally give us a 504. It's not the end of the world, but this could be an easy, free fix.Cheers!