fix(BA-793): Filter GQL sentinel value during endpoint rule creation #3757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregataa
added
the
skip:changelog
github-actions
bot
added
comp:manager
fregataa
changed the title
fregataa
changed the title
graphite-app bot
pushed a commit
to lablup/backend.ai-webui
that referenced
this pull request
Feb 19, 2025
…#3202) Resolves #3201 (FR-555) ### TL;DR > For test, please pull this lablup/backend.ai#3757 to your test server Redesigned the auto-scaling rule editor interface to improve usability and add separate controls for scale up/down operations. ### What changed? - Added distinct scale up/down options instead of combining them - Simplified metric selection with autocomplete and predefined options - Consolidated condition inputs (metric, comparator, threshold) into a single row - Removed redundant min/max replica fields based on scaling direction - Added tooltips and improved validation logic - Updated translations for all supported languages with new UI strings ### How to test? 1. Open the endpoint detail page 2. Click to add a new auto-scaling rule 3. Verify the new UI with separate scale up/down options 4. Test metric name autocomplete functionality 5. Confirm min/max replicas show correctly based on scale direction 6. Validate form submissions work for both scale up and down scenarios ### Why make this change? The previous interface combined scale up/down operations which made it confusing for users to configure rules correctly. This redesign separates the concerns and provides a more intuitive workflow while reducing potential configuration errors through better validation and clearer UI elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3756 (BA-793)
Checklist: (if applicable)