Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BA-749): Handle None arguments properly in ContainerRegistryNode GQL API #3697

Closed
wants to merge 3 commits into from

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Feb 13, 2025

Resolves #3698 (BA-749).

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

@github-actions github-actions bot added comp:manager Related to Manager component size:XS ~10 LoC labels Feb 13, 2025
@jopemachine jopemachine changed the title fix: Handle None type argument properly fix: Handle None type argument properly in ContainerRegistryNode GQL API Feb 13, 2025
@jopemachine jopemachine changed the title fix: Handle None type argument properly in ContainerRegistryNode GQL API fix(BA-749): Handle None type argument properly in ContainerRegistryNode GQL API Feb 13, 2025
@jopemachine jopemachine changed the title fix(BA-749): Handle None type argument properly in ContainerRegistryNode GQL API fix(BA-749): Handle None arguments properly in ContainerRegistryNode GQL API Feb 13, 2025
@jopemachine jopemachine added this to the 24.09 milestone Feb 13, 2025
@github-actions github-actions bot added size:M 30~100 LoC and removed size:XS ~10 LoC labels Feb 13, 2025
@jopemachine jopemachine marked this pull request as ready for review February 13, 2025 09:51
@jopemachine jopemachine marked this pull request as draft February 13, 2025 09:54
@jopemachine
Copy link
Member Author

If we treat null as a missing value, it causes an issue where we can't insert null into nullable columns like DB username and password.

This issue can be resolved by using the new V2 mutation introduced in #3418.
So I'll close this PR as not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None value fields are not being handled correctly in ContainerRegistryNode GQL
1 participant