Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BA-675): Implement Image status filtering logics #3647

Open
wants to merge 10 commits into
base: topic/02-10-feat_implment_image_soft_hard_delete_apis
Choose a base branch
from

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Feb 11, 2025

Resolves #3618 (BA-675).

Images marked as "DELETED" cannot be used in CLI commands by default (e.g., inspect).
Similarly, "DELETED" images are not retrieved in GQL by default.
If you want to retrieve "DELETED" images, set load_only_active to False.

Checklist: (if applicable)

  • Mention to the original issue

📚 Documentation preview 📚: https://sorna--3647.org.readthedocs.build/en/3647/


📚 Documentation preview 📚: https://sorna-ko--3647.org.readthedocs.build/ko/3647/

@jopemachine jopemachine self-assigned this Feb 11, 2025
@github-actions github-actions bot added comp:manager Related to Manager component comp:cli Related to CLI component size:L 100~500 LoC labels Feb 11, 2025
@jopemachine jopemachine added this to the 25Q1 milestone Feb 11, 2025
Copy link
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jopemachine jopemachine marked this pull request as draft February 11, 2025 04:17
@jopemachine jopemachine changed the title fix: Apply image status-based filtering feat(BA-675): Apply image status-based filtering Feb 11, 2025
@jopemachine jopemachine force-pushed the topic/02-11-fix_apply_image_status-based_filtering branch 3 times, most recently from ac354ab to 6edb239 Compare February 11, 2025 04:50
@github-actions github-actions bot added the area:docs Documentations label Feb 11, 2025
@jopemachine jopemachine force-pushed the topic/02-11-fix_apply_image_status-based_filtering branch from 2dedaa9 to 8fd4d77 Compare February 11, 2025 05:58
@jopemachine jopemachine changed the title feat(BA-675): Apply image status-based filtering feat(BA-675): Implement Image status filtering logics Feb 11, 2025
@jopemachine jopemachine force-pushed the topic/02-10-feat_implment_image_soft_hard_delete_apis branch from 6c6e0de to 4403c81 Compare February 17, 2025 05:47
@jopemachine jopemachine force-pushed the topic/02-11-fix_apply_image_status-based_filtering branch from 0b946da to 066c2c2 Compare February 17, 2025 05:47
@jopemachine jopemachine force-pushed the topic/02-10-feat_implment_image_soft_hard_delete_apis branch from 4403c81 to abe5f22 Compare February 17, 2025 05:57
@jopemachine jopemachine force-pushed the topic/02-11-fix_apply_image_status-based_filtering branch from 066c2c2 to 057c3d8 Compare February 17, 2025 05:57
@jopemachine jopemachine force-pushed the topic/02-10-feat_implment_image_soft_hard_delete_apis branch from abe5f22 to fdd6902 Compare February 17, 2025 06:01
@jopemachine jopemachine force-pushed the topic/02-11-fix_apply_image_status-based_filtering branch from 057c3d8 to e2ba548 Compare February 17, 2025 06:01
@jopemachine jopemachine force-pushed the topic/02-10-feat_implment_image_soft_hard_delete_apis branch from fdd6902 to cdf1e63 Compare February 18, 2025 03:35
@jopemachine jopemachine force-pushed the topic/02-11-fix_apply_image_status-based_filtering branch 2 times, most recently from 323d363 to 2d7da7b Compare February 18, 2025 03:36
@jopemachine jopemachine force-pushed the topic/02-10-feat_implment_image_soft_hard_delete_apis branch from e7297ed to 26da8ef Compare February 18, 2025 03:52
@jopemachine jopemachine force-pushed the topic/02-11-fix_apply_image_status-based_filtering branch 2 times, most recently from 20bd95a to 9d8ce1a Compare February 18, 2025 03:53
@jopemachine jopemachine force-pushed the topic/02-10-feat_implment_image_soft_hard_delete_apis branch from 726df8a to 581d7ce Compare February 18, 2025 03:55
@jopemachine jopemachine force-pushed the topic/02-11-fix_apply_image_status-based_filtering branch from 9d8ce1a to b341df9 Compare February 18, 2025 03:55
@jopemachine jopemachine marked this pull request as ready for review February 18, 2025 05:32
@jopemachine jopemachine force-pushed the topic/02-10-feat_implment_image_soft_hard_delete_apis branch from 581d7ce to f75988e Compare February 18, 2025 05:37
@jopemachine jopemachine force-pushed the topic/02-11-fix_apply_image_status-based_filtering branch from 0a5358b to 12e6e33 Compare February 18, 2025 05:37
@jopemachine jopemachine force-pushed the topic/02-11-fix_apply_image_status-based_filtering branch 3 times, most recently from 54435b0 to 1177357 Compare February 19, 2025 04:57
@jopemachine jopemachine force-pushed the topic/02-10-feat_implment_image_soft_hard_delete_apis branch from 6484405 to ad292e6 Compare February 19, 2025 04:57
@jopemachine jopemachine force-pushed the topic/02-11-fix_apply_image_status-based_filtering branch from 1177357 to 487c3e4 Compare February 19, 2025 05:01
@jopemachine jopemachine force-pushed the topic/02-11-fix_apply_image_status-based_filtering branch from 4def582 to af6919a Compare February 20, 2025 07:46
@jopemachine jopemachine force-pushed the topic/02-11-fix_apply_image_status-based_filtering branch from af6919a to 970313c Compare February 20, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:cli Related to CLI component comp:manager Related to Manager component size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants