gpiodriver: allow GpioDigitalOutputDriver match against MatchedSysfsGPIO #1646
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation states that the GpioDigitalOutputDriver should bind to
the following three 'gpio' options:
- SysfsGPIO
- MatchedSysfsGPIO
- NetworkSysfsGPIO
However, the bindings list is:
bindings = {
"gpio": {"SysfsGPIO", "NetworkSysfsGPIO"},
}
and as a result, if I try to bind these two in an environment, I see
errors like:
labgrid.exceptions.NoSupplierFoundError: binding copilot-output-driver failed: no supplier matching {'NetworkSysfsGPIO', 'SysfsGPIO'} found in Target(name='beagleplay', env=Environment(config_file='bp-conf2.yaml')) (errors: [NoResourceFoundError(msg="no NetworkSysfsGPIO resource found in Target(name='beagleplay', env=Environment(config_file='bp-conf2.yaml'))", filter=None, found=None), NoResourceFoundError(msg="no SysfsGPIO resource found in Target(name='beagleplay', env=Environment(config_file='bp-conf2.yaml'))", filter=None, found=None)])
Adjust the list to include MatchedSysfsGPIO so that this works (and so
that the docs are correct).
Signed-off-by: Trevor Gamblin <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #1646 +/- ##
======================================
Coverage 55.8% 55.8%
======================================
Files 170 170
Lines 13388 13388
======================================
Hits 7471 7471
Misses 5917 5917
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Not clear to me why the Otherwise looks OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation states that the GpioDigitalOutputDriver should bind to the following three 'gpio' options:
However, the bindings list is:
and as a result, if I try to bind these two in an environment, I see errors like:
labgrid.exceptions.NoSupplierFoundError: binding copilot-output-driver failed: no supplier matching {'NetworkSysfsGPIO', 'SysfsGPIO'} found in Target(name='beagleplay', env=Environment(config_file='bp-conf2.yaml')) (errors: [NoResourceFoundError(msg="no NetworkSysfsGPIO resource found in Target(name='beagleplay', env=Environment(config_file='bp-conf2.yaml'))", filter=None, found=None), NoResourceFoundError(msg="no SysfsGPIO resource found in Target(name='beagleplay', env=Environment(config_file='bp-conf2.yaml'))", filter=None, found=None)])
Adjust the list to include MatchedSysfsGPIO so that this works (and so that the docs are correct).