feat: Improved Chord dictionary & Chord detection #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -78,6 +65,19 @@ | |||
| const i = chord.notes.findIndex((note) => Note.chroma(note) === Note.chroma(pc)); | |||
| if (i < 0) return ''; | |||
|
|
|||
| return chord.intervals[i]; | |||
| return chord.intervals[i].replace('*', ''); | |||
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
| }); | ||
| } | ||
|
|
||
| export function removeIntervalWildcards(intervals: string[]) { | ||
| return intervals.map((interval) => interval.replace('*', '')); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
ArTiSTiX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded to tonal v5, which normally implements detecting chords assuming perfect Fifths.
But the tonal dictionary is incomplete and chord notation is not consistent.
So until tonal is updated, MIDI Jar will use a custom chord dictionary (more complete and indicating intervals that can be omitted), and a detection feature that allows omissions in chords.
It would let me fixing and completing the chord dictionary to update tonal.
Added:
NOTE:
Chord Quiz will by improved later to have more custom gameplay like allowing omissions too, being more strict, or even asking for a specific bass note / inversion.