Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dimension pop-in configuration #219

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Conversation

Flowtter
Copy link
Contributor

This pull request allows the user to use a unit other than pixels.

{
  "name": "",
...
  "popInConfiguration": {
    "width": "29.5vw",
    "height": "22.5vw",
    "position": "center",
    "yt": true,
    "className": "wood-style with-arrow fade-in v-centered",
    "offset": {
      "x": 0,
      "y": 0
    }
  },
...
}

@Donorhan
Copy link
Contributor

Thank you!

@Donorhan Donorhan merged commit 1f0d939 into l3mpire:master Nov 24, 2022
@Donorhan
Copy link
Contributor

This is not related to your change but I just saw in your example a "yt": true, it is not necessary anymore. From now on the detection of youtube lin, the addition of the mandatory parameters is automatic

xsyann pushed a commit to Refty/lemverse that referenced this pull request Nov 24, 2022
xsyann pushed a commit to Refty/lemverse that referenced this pull request Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants