Add settings to configure features on level editor #139

ramnes · 2022-09-29T15:38:02Z

There are features that level admins may want to enable or disable on their level, so here we're giving them the chance to do just that with:

the voice amplifier
the global chat
punches

alimtunc · 2022-10-11T15:12:56Z

Added settings for all other radial actions 🙌

ramnes · 2022-10-11T15:31:35Z

Nice! @YglesEyes maybe you could use this as a starting point for what we've just mentioned in #161 ?

YglesEyes · 2022-10-13T07:41:16Z

Nice! @YglesEyes maybe you could use this as a starting point for what we've just mentioned in #161 ?

Yes thanks, I just wait for Donorhan back (on monday) to discuss with him before doing anything

ramnes · 2022-10-25T08:50:19Z

@Donorhan Anything we can do to help on that one?

xsyann · 2022-10-25T10:05:55Z

core/modules/shout-ability/client/shout-ability.js

@@ -1,26 +1,48 @@
-import { moduleType } from '../../../client/helpers';
+import { canUseLevelFeature, moduleType } from '../../../lib/misc';


moduleType should be imported from '../../../client/helpers'

xsyann · 2022-10-25T10:57:39Z

core/client/ui/radial-menu.js

+
+  // If it's an admin, we show the item but if it's disabled for all, the action will be ignored
+  const isAdmin = user.roles?.admin;
+  if (!isAdmin && !canUseLevelFeature(user, 'reactions')) mainMenuItems.splice(0, 1);


splice(0,1) removes notifications not reactions

xsyann · 2022-10-25T11:02:08Z

core/modules/shout-ability/client/shout-ability.js

    moduleType.RADIAL_MENU,
-  ]);
+      ]);


The bracket is misplaced, registerModules should take 2 params

xsyann · 2022-10-25T11:02:31Z

core/modules/textual-communication-tools/client/textual-communication-tools.js

    moduleType.RADIAL_MENU,
-  );
+  ]);


xsyann · 2022-10-25T11:02:44Z

core/modules/textual-communication-tools/client/textual-communication-tools.js

+      registerModules([
+        { id: 'send-text', icon: '💬', shortcut: 56, order: 41, label: 'Text', closeMenu: true, scope: 'other' },
+    moduleType.RADIAL_MENU,
+      ]);


xsyann · 2022-10-25T11:03:42Z

Maybe we should also add a setting for tasks and inventory?

Donorhan

Sounds good to me thanks! I left a few comments, it's not blocking but it would make it easier to add permissions later I think 😊

core/client/ui/radial-menu.js

Donorhan · 2022-10-27T12:54:05Z

core/client/ui/toolboxes/level-toolbox.js

@@ -39,6 +45,30 @@ Template.levelToolbox.events({
    const { x, y } = user.profile;
    updateLevel(level.name, { x, y }, level.hide);
  },
+  'change .js-voice-amplifier-select'(event) {


A small idea to have less code: add a data-permission="xxx" then on the JS side do something like:

'change .permission-list select'(event) { const { permission } = event.target.dataset; updateFeaturePermissionLevel(permission, event); },

So cool, I searched for something like this but couldn't find, good to know :)

Donorhan · 2022-10-27T12:57:27Z

core/modules/shout-ability/client/shout-ability.js


  hotkeys('r', { keyup: true, scope: scopes.player }, event => {
    if (event.repeat) return;
+
+    const user = Meteor.user({ fields: { _id: 1, 'profile.levelId': 1, roles: 1 } });


I think we can make it simpler to avoid code repetition:
Have a variable local to the file and update it against the condition line 13. Then in the rest of the functions rely on this variable

Donorhan · 2022-10-27T12:59:26Z

core/client/ui/toolboxes/level-toolbox.hbs.html

@@ -10,7 +10,75 @@
        <label for="level-toolbox-hidden">Hide from the list of levels</label>
      </div>
      <div>
-        <button id="level-toolbox-position" type="button" class="js-spawn-position button">Set spawn position (current {{ spawnPosition }})</button>
+        <div class="feature-dropdown">


Wouldn't it be better to loop over a permission array?

There are features that level admins may want to enable or disable on their level, so here we're giving them the chance to do just that with: * the voice amplifier * the global chat * punches

alimtunc · 2022-11-14T09:43:21Z

@Donorhan What about this PR ? Is it good for you or need changes ?

ramnes force-pushed the level-permissions branch from 2e4c9d4 to a4a2bef Compare September 29, 2022 15:38

ramnes requested a review from Donorhan September 29, 2022 15:39

ramnes added the enhancement label Sep 29, 2022

ramnes mentioned this pull request Sep 30, 2022

Allow admins to set custom permissions on guest users #136

Merged

alimtunc mentioned this pull request Oct 7, 2022

Feature flags #74

Open

alimtunc force-pushed the level-permissions branch 2 times, most recently from 0288f5d to 7030281 Compare October 10, 2022 08:25

ramnes mentioned this pull request Oct 11, 2022

1 - Developer can disabled tchat tools in settings #161

Merged

alimtunc force-pushed the level-permissions branch from a89075a to be9c675 Compare October 12, 2022 08:44

alimtunc force-pushed the level-permissions branch from be9c675 to 4d06fc6 Compare October 24, 2022 09:02

xsyann reviewed Oct 25, 2022

View reviewed changes

core/modules/textual-communication-tools/client/textual-communication-tools.js Outdated

moduleType.RADIAL_MENU,

);

]);

Copy link

Contributor

xsyann Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too

xsyann reviewed Oct 25, 2022

View reviewed changes

alimtunc force-pushed the level-permissions branch from 4d06fc6 to 528fe80 Compare October 26, 2022 16:44

Donorhan reviewed Oct 27, 2022

View reviewed changes

alimtunc force-pushed the level-permissions branch from 528fe80 to 8f9c0fc Compare October 27, 2022 15:54

alimtunc added 2 commits October 27, 2022 17:54

Add settings to configure features on level editor

3c6b1b1

There are features that level admins may want to enable or disable on their level, so here we're giving them the chance to do just that with: * the voice amplifier * the global chat * punches

Add levels settings for all radial menu actions

b8a8886

alimtunc force-pushed the level-permissions branch from 8f9c0fc to b8a8886 Compare October 27, 2022 15:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add settings to configure features on level editor #139

Add settings to configure features on level editor #139

ramnes commented Sep 29, 2022 •

edited

Loading

alimtunc commented Oct 11, 2022

ramnes commented Oct 11, 2022

YglesEyes commented Oct 13, 2022

ramnes commented Oct 25, 2022

xsyann Oct 25, 2022

xsyann Oct 25, 2022

xsyann Oct 25, 2022

xsyann Oct 25, 2022

xsyann Oct 25, 2022

xsyann commented Oct 25, 2022

Donorhan left a comment

Donorhan Oct 27, 2022

alimtunc Oct 27, 2022

Donorhan Oct 27, 2022

Donorhan Oct 27, 2022

alimtunc commented Nov 14, 2022

		@@ -1,26 +1,48 @@
		import { moduleType } from '../../../client/helpers';
		import { canUseLevelFeature, moduleType } from '../../../lib/misc';

Add settings to configure features on level editor #139

Are you sure you want to change the base?

Add settings to configure features on level editor #139

Conversation

ramnes commented Sep 29, 2022 • edited Loading

alimtunc commented Oct 11, 2022

ramnes commented Oct 11, 2022

YglesEyes commented Oct 13, 2022

ramnes commented Oct 25, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xsyann commented Oct 25, 2022

Donorhan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alimtunc commented Nov 14, 2022

ramnes commented Sep 29, 2022 •

edited

Loading