-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add separate workflow for CEL policies to unblock e2e tests #1087
Conversation
Signed-off-by: Chandan-DK <[email protected]>
d6aefb0
to
87d3fbf
Compare
Made this PR by mistake. Was trying to find a way to avoid |
Yes, I think this would be a good approach! Please do reopen! |
Hi @Chandan-DK - let us know if you are still interested in contribution! |
Hi! I will get this PR in shape for review 🙌 |
20e7b56
to
65b8f4e
Compare
Signed-off-by: Chandan-DK <[email protected]>
65b8f4e
to
9eb027f
Compare
Signed-off-by: Chandan-DK <[email protected]>
Thanks @Chandan-DK ! All new tests failed due to this:
Looks like something is missing, can you take a look? |
…yverno#10313 Signed-off-by: Chandan-DK <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we rename the .chainsaw-test
directory of the problematic policy rather than just deleting it?
Sure, but there will still be noise in the CI since Chainsaw executes the |
I would ask @eddycharly what's the most reliable thing to do here. I'm not sure what the current recommended approach is for Chainsaw given its present state. |
Chainsaw by default looks for the By the way, the policies that have been deleted due to this issue are being tracked here. I have been referencing the link of the issue in my commits when deleting policies. We could use those commits to help add the policies back when the issue is resolved. |
Ok, that sounds good. Let's give it a try. |
Signed-off-by: Chandan-DK <[email protected]>
… running for verify-git-repositories policy Signed-off-by: Chandan-DK <[email protected]>
0aab673
to
91c1f2d
Compare
Signed-off-by: Chandan-DK <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much thanks! I'm going to go ahead and merge this so we can run our e2e tests again.
Good job @Chandan-DK ! |
Thanks @realshuting @chipzoller ! |
Related Issue(s)
Description
This PR resolves
Strategy expansion exceeded 256 results for job 'chainsaw'
error that is currently blocking the E2E tests from running.A separate workflow file has been created for CEL policies and this PR makes use of composite actions to reuse steps in both the workflow files (
test.yml
andcel-test.yml
)Checklist