Skip to content

Commit

Permalink
use github builtins as fallback
Browse files Browse the repository at this point in the history
Signed-off-by: Frank Jogeleit <[email protected]>
  • Loading branch information
fjogeleit committed Jan 27, 2025
1 parent 604cfd5 commit 5196ed2
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
2 changes: 1 addition & 1 deletion backend/pkg/resource/load_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ spec:
)

func Test_LoadResources(t *testing.T) {
l, err := loader.New(openapiclient.NewHardcodedBuiltins("1.27"))
l, err := loader.New(openapiclient.NewHardcodedBuiltins("1.28"))
if err != nil {
t.Fatal(err)
}
Expand Down
8 changes: 7 additions & 1 deletion backend/pkg/server/api/engine/request.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,13 @@ func (r *EngineRequest) ResourceLoader(cluster cluster.Cluster, kubeVersion stri
if err != nil {
return nil, err
}
clients = append(clients, openapiclient.NewHardcodedBuiltins(kubeVersion))

client := openapiclient.NewHardcodedBuiltins(kubeVersion)
if _, err := client.Paths(); err == nil {
clients = append(clients, client)
} else {
clients = append(clients, openapiclient.NewGitHubBuiltins(kubeVersion))
}
}
clients = append(clients, openapiclient.NewLocalSchemaFiles(data.Schemas(), "schemas"))
if len(r.CustomResourceDefinitions) != 0 {
Expand Down
6 changes: 6 additions & 0 deletions release-notes/v0.4.3.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Release notes

Release notes for `v0.4.4`.

## :wrench: Fixes :wrench:
- Use GitHub buildins for unknown Kubernetes versions

0 comments on commit 5196ed2

Please sign in to comment.