feat: separate deny and allow rules #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
==========================================
+ Coverage 27.20% 29.07% +1.87%
==========================================
Files 30 30
Lines 1066 1183 +117
==========================================
+ Hits 290 344 +54
- Misses 728 791 +63
Partials 48 48 ☔ View full report in Codecov by Sentry. |
eddycharly
force-pushed
the
allow-deny
branch
5 times, most recently
from
9120711 to
2b1c9a4
Compare
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
eddycharly
force-pushed
the
allow-deny
branch
10 times, most recently
from
eddfd65 to
a8ea3e1
Compare
eddycharly
force-pushed
the
allow-deny
branch
2 times, most recently
from
2678bd5 to
a5b095a
Compare
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
eddycharly
force-pushed
the
allow-deny
branch
from
a5b095a to
3768509
Compare
Yup, response types are different though i will make it generic. |
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
|
@vishal-chdhry i made changes to reduce the duplicated parts |
vishal-chdhry
approved these changes
Dec 30, 2024
fjogeleit
approved these changes
Dec 30, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Separate deny and allow rules.