fix: add pet namespace if necessary

Signed-off-by: Charles-Edouard Brétéché <[email protected]>

.github/workflows/tests.yaml

@@ -36,6 +36,8 @@ jobs:
         with:
           go-version-file: go.mod
           cache-dependency-path: go.sum
+      - name: Create test cluster
+        run: make kind-cluster
       - name: Run tests
         run: make tests
       - name: Upload Report to Codecov

pkg/client/client.go

@@ -1,6 +1,7 @@
 package client
 
 import (
+	"k8s.io/apimachinery/pkg/runtime"
 	_ "k8s.io/client-go/plugin/pkg/client/auth" // package needed for auth providers like GCP
 	"k8s.io/client-go/rest"
 	ctrlclient "sigs.k8s.io/controller-runtime/pkg/client"
@@ -9,6 +10,7 @@ import (
 type Client interface {
 	ctrlclient.Reader
 	ctrlclient.Writer
+	IsObjectNamespaced(obj runtime.Object) (bool, error)
 }
 
 func New(cfg *rest.Config) (Client, error) {

pkg/runner/runner.go

@@ -73,20 +73,30 @@ func runTest(t *testing.T, cfg *rest.Config, test discovery.Test) {
 		step := test.Spec.Steps[i]
 		t.Run(fmt.Sprintf("step-%d", i+1), func(t *testing.T) {
 			t.Helper()
-			executeStep(t, test.BasePath, step, c)
+			executeStep(t, test.BasePath, namespace.Name, step, c)
 		})
 	}
 }
 
-func executeStep(t *testing.T, basePath string, step v1alpha1.TestStepSpec, c client.Client) {
+func executeStep(t *testing.T, basePath string, namespace string, step v1alpha1.TestStepSpec, c client.Client) {
 	t.Helper()
 	for _, apply := range step.Apply {
 		resources, err := resource.Load(filepath.Join(basePath, apply.File))
 		if err != nil {
 			t.Fatal(err)
 		}
 		for i := range resources {
-			_, err := client.CreateOrUpdate(context.Background(), c, &resources[i])
+			resource := &resources[i]
+			if resource.GetNamespace() == "" {
+				namespaced, err := c.IsObjectNamespaced(resource)
+				if err != nil {
+					t.Fatal(err)
+				}
+				if namespaced {
+					resource.SetNamespace(namespace)
+				}
+			}
+			_, err := client.CreateOrUpdate(context.Background(), c, resource)
 			if err != nil {
 				t.Fatal(err)
 			}

testdata/tests/configmap.yaml

@@ -2,6 +2,5 @@ apiVersion: v1
 kind: ConfigMap
 metadata:
   name: chainsaw-quick-start
-  namespace: default
 data:
   foo: bar