-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: implements a underscore validation to camelcase plugin #1290
Draft
RyanV-Souza
wants to merge
5
commits into
kysely-org:master
Choose a base branch
from
RyanV-Souza:fix/duplicate-underscore-camelcase
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fix: implements a underscore validation to camelcase plugin #1290
RyanV-Souza
wants to merge
5
commits into
kysely-org:master
from
RyanV-Souza:fix/duplicate-underscore-camelcase
+71
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RyanV-Souza
changed the title
feat: implements a underscore validation to camelcase plugin
fix: implements a underscore validation to camelcase plugin
Dec 11, 2024
…om/RyanV-Souza/kysely into fix/duplicate-underscore-camelcase
Thanks for the review, I've updated the code to be in line with the reviews and the good practices of the repository |
Open in Stackblitz • kysely_koa_example
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my proposed solution to issue #1281 . If there are alternative approaches or suggestions, I would be happy to discuss them.