Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add sample code to use Kysely in Deno & manage migrations #1011

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Docs: Add sample code to use Kysely in Deno & manage migrations #1011

wants to merge 6 commits into from

Conversation

Sleepful
Copy link

Hello!

It took me a while to figure out this one, here I hope to make it easier to others.

@vercel Vercel
Copy link

vercel bot commented May 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 10:58pm

@Sleepful
Copy link
Author

I can't see the details of the CI failing 😅

Sleepful
Sleepful commented May 29, 2024
View reviewed changes
site/docs/runtimes/deno.mdx
@@ -52,3 +52,35 @@ const sql = query.compile()

console.log(sql.sql)
```

Deno works well with [PostgresJS](https://github.com/porsager/postgres), to that end you can use the Kysely dialect and the driver:
Copy link
Author

@Sleepful Sleepful May 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if I should remove the explanation above this one in the file so I left it there.

@Sleepful Sleepful changed the title Add sample code to use Kysely in Deno Add sample code to use Kysely (and migrations) in Deno May 29, 2024
@Sleepful Sleepful changed the title Add sample code to use Kysely (and migrations) in Deno Docs: Add sample code to use Kysely in Deno & manage migrations May 29, 2024
@Sleepful
Copy link
Author

@igalklebanov hello 👋 do you think this documentation is helpful?

@igalklebanov igalklebanov added the documentation Improvements or additions to documentation label Jun 16, 2024
@igalklebanov
Copy link
Member

I can't see the details of the CI failing 😅

Did you run your changes locally?

image

@Sleepful
Copy link
Author

Oh yeah, I was using npm start and it didn't error.
Now that I see your screenshot, I see that I should have been running npm run build to check.

I updated the PR:

@Sleepful
Copy link
Author

I can continue updating with master branch, but first I will wait to get approval or feedback on the changes

@Thaigun
Copy link

Thaigun commented Nov 14, 2024

Just letting y'all know that the example was useful fo me, in particular DenoMigrationProvider. 😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sleepful @igalklebanov @Thaigun