Suppressing SA1127 SA1128 (:base, where T)

kysect · Jan 4, 2023 · f62e9e1 · f62e9e1
1 parent 9c1ed23
commit f62e9e1
Show file tree

Hide file tree

Showing 11 changed files with 15 additions and 27 deletions.
diff --git a/Source/Directory.Build.props b/Source/Directory.Build.props
@@ -3,7 +3,7 @@
         <AnalysisLevel>latest</AnalysisLevel>
         <EnforceCodeStyleInBuild>True</EnforceCodeStyleInBuild>
         <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-        <NoWarn>1591;SA1633;SA1101;SA1503;SA1309;SA1601;SA1201;SA1502</NoWarn>
+        <NoWarn>1591;SA1633;SA1101;SA1503;SA1309;SA1601;SA1201;SA1502;SA1127;SA1128</NoWarn>
     </PropertyGroup>
     <ItemGroup>
         <PackageReference Include="StyleCop.Analyzers">

diff --git a/Source/Domain/Kysect.Shreks.Common/Exceptions/RegistrationFailedException.cs b/Source/Domain/Kysect.Shreks.Common/Exceptions/RegistrationFailedException.cs
@@ -2,6 +2,5 @@ namespace Kysect.Shreks.Common.Exceptions;
 
 public class RegistrationFailedException : ShreksDomainException
 {
-    public RegistrationFailedException(string? message)
-        : base(message) { }
+    public RegistrationFailedException(string? message) : base(message) { }
 }
diff --git a/Source/Domain/Kysect.Shreks.Common/Exceptions/ShreksDomainException.cs b/Source/Domain/Kysect.Shreks.Common/Exceptions/ShreksDomainException.cs
@@ -4,9 +4,7 @@ public abstract class ShreksDomainException : Exception
 {
     protected ShreksDomainException() { }
 
-    protected ShreksDomainException(string? message)
-        : base(message) { }
+    protected ShreksDomainException(string? message) : base(message) { }
 
-    protected ShreksDomainException(string? message, Exception? innerException)
-        : base(message, innerException) { }
+    protected ShreksDomainException(string? message, Exception? innerException) : base(message, innerException) { }
 }
diff --git a/Source/Domain/Kysect.Shreks.Common/Exceptions/StudentAssignmentException.cs b/Source/Domain/Kysect.Shreks.Common/Exceptions/StudentAssignmentException.cs
@@ -4,8 +4,7 @@ namespace Kysect.Shreks.Common.Exceptions;
 
 public class StudentAssignmentException : ShreksDomainException
 {
-    private StudentAssignmentException(string message)
-        : base(message) { }
+    private StudentAssignmentException(string message) : base(message) { }
 
     public static StudentAssignmentException StudentGroupAssignmentMismatch(string student, string group)
     {

diff --git a/Source/Domain/Kysect.Shreks.Common/Exceptions/UnauthorizedException.cs b/Source/Domain/Kysect.Shreks.Common/Exceptions/UnauthorizedException.cs
@@ -4,8 +4,7 @@ namespace Kysect.Shreks.Common.Exceptions;
 
 public class UnauthorizedException : ShreksDomainException
 {
-    public UnauthorizedException(string? message)
-        : base(message) { }
+    public UnauthorizedException(string? message) : base(message) { }
 
     public UnauthorizedException()
         : base(UserMessages.UnauthorizedExceptionMessage) { }

diff --git a/Source/Domain/Kysect.Shreks.Core/Users/User.cs b/Source/Domain/Kysect.Shreks.Core/Users/User.cs
@@ -55,14 +55,12 @@ public void RemoveAssociation(UserAssociation association)
             throw new DomainInvalidOperationException($"User {this} could not remove association {association}");
     }
 
-    public bool HasAssociation<T>()
-        where T : UserAssociation
+    public bool HasAssociation<T>() where T : UserAssociation
     {
         return Associations.Any(a => a is T);
     }
 
-    public T? FindAssociation<T>()
-        where T : UserAssociation
+    public T? FindAssociation<T>() where T : UserAssociation
     {
         return Associations.OfType<T>().SingleOrDefault();
     }

diff --git a/Source/Presentation/Kysect.Shreks.Controllers/IControllerProjectMarker.cs b/Source/Presentation/Kysect.Shreks.Controllers/IControllerProjectMarker.cs
@@ -1,3 +1,3 @@
 namespace Kysect.Shreks.Controllers;
 
-public interface IControllersProjectMarker { }
+public interface IControllerProjectMarker { }
diff --git a/Source/Presentation/Kysect.Shreks.Controllers/Kysect.Shreks.Controllers.csproj b/Source/Presentation/Kysect.Shreks.Controllers/Kysect.Shreks.Controllers.csproj
@@ -6,7 +6,7 @@
         <Nullable>enable</Nullable>
         <AnalysisLevel>latest</AnalysisLevel>
         <EnforceCodeStyleInBuild>True</EnforceCodeStyleInBuild>
-        <NoWarn>1701;1702;CA1062;SA1101;SA1309;SA1633;SA1503</NoWarn>
+        <NoWarn>1701;1702;CA1062;SA1101;SA1309;SA1633;SA1503;SA1127;SA1128;SA1502</NoWarn>
     </PropertyGroup>
 
     <ItemGroup>

diff --git a/Source/Presentation/Kysect.Shreks.WebUI.AdminPanel/SafeExecution/ExceptionHandler.cs b/Source/Presentation/Kysect.Shreks.WebUI.AdminPanel/SafeExecution/ExceptionHandler.cs
@@ -1,7 +1,6 @@
 namespace Kysect.Shreks.WebUI.AdminPanel.SafeExecution;
 
-public class ExceptionHandler<T> : IExceptionHandler
-    where T : Exception
+public class ExceptionHandler<T> : IExceptionHandler where T : Exception
 {
     private readonly Func<T, Task> _handler;
 

diff --git a/Source/Presentation/Kysect.Shreks.WebUI.AdminPanel/SafeExecution/ISafeExecutionBuilder.cs b/Source/Presentation/Kysect.Shreks.WebUI.AdminPanel/SafeExecution/ISafeExecutionBuilder.cs
@@ -6,8 +6,7 @@ public interface ISafeExecutionBuilder : IAsyncDisposable
 
     bool ShowExceptionDetails { get; set; }
 
-    void OnFailAsync<TException>(Func<TException, Task> action)
-        where TException : Exception;
+    void OnFailAsync<TException>(Func<TException, Task> action) where TException : Exception;
 
     void OnSuccessAsync(Func<Task> action);
 }
@@ -18,8 +17,7 @@ public interface ISafeExecutionBuilder<out T> : IAsyncDisposable
 
     bool ShowExceptionDetails { get; set; }
 
-    void OnFailAsync<TException>(Func<TException, Task> action)
-        where TException : Exception;
+    void OnFailAsync<TException>(Func<TException, Task> action) where TException : Exception;
 
     void OnSuccessAsync(Func<T, Task> action);
 }
diff --git a/Source/Presentation/Kysect.Shreks.WebUI.AdminPanel/SafeExecution/SafeExecutionBuilder.cs b/Source/Presentation/Kysect.Shreks.WebUI.AdminPanel/SafeExecution/SafeExecutionBuilder.cs
@@ -33,8 +33,7 @@ public SafeExecutionBuilder(
 
     public bool ShowExceptionDetails { get; set; }
 
-    public void OnFailAsync<TException>(Func<TException, Task> action)
-        where TException : Exception
+    public void OnFailAsync<TException>(Func<TException, Task> action) where TException : Exception
     {
         _errorHandlers.Add(new ExceptionHandler<TException>(action));
     }
@@ -107,8 +106,7 @@ public SafeExecutionBuilder(
 
     public bool ShowExceptionDetails { get; set; }
 
-    public void OnFailAsync<TException>(Func<TException, Task> action)
-        where TException : Exception
+    public void OnFailAsync<TException>(Func<TException, Task> action) where TException : Exception
     {
         _errorHandlers.Add(new ExceptionHandler<TException>(action));
     }