Paste Image feature #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 27, 2025 15:02
kynan
requested changes
Mar 1, 2025
plugin/dokuvimki.py
Outdated
| @@ -9,6 +9,11 @@ | |||
| import time | |||
| import subprocess | |||
|
|
|||
| from PIL import ImageGrab | |||
There was a problem hiding this comment.
In this case I think moving the import into the paste_image function might be prudent: with a top-level import, PIL becomes a required dependency even if one never uses pasting from the clipboard. wdyt?
There was a problem hiding this comment.
I've used the same way like xmlrpc check and included a check inside the pasteimage function including error message on missing module.
There was a problem hiding this comment.
I'm slightly confused what this file is needed for?
There was a problem hiding this comment.
Sorry that whole folder shouldn't be there it happend by mistake will remove it.
dokuvimki_ORIG_NONO/README.md
Outdated
There was a problem hiding this comment.
I'm slightly confused what this file is needed for?
kynan
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #27 here is the PR