Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read access token to use it in authentication. #12123

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Read access token to use it in authentication. #12123

merged 6 commits into from
Oct 16, 2024

Conversation

dekiel
Copy link
Contributor

@dekiel dekiel commented Oct 10, 2024 •
edited
Loading

Description

The access token was not passed to the sync function, this was causing creating authenticator with empty access token.

Changes proposed in this pull request:

  • Extracted creating authenticator to the separate function. Created authenticator contains a key or token already.
  • Sync function receive an authenticator as argument instead key or token.
  • Move ginkgo tests entrypoint to the suite tests file to have one entry point for all ginkgo tests.

Related issue(s)
See: #11384

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2024
@dekiel
Extract building new authenticator to separate function. The authenti…
84d5141 
…cator passed to the sync function already contains key or token.
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2024
@dekiel dekiel marked this pull request as ready for review October 11, 2024 06:40
@dekiel dekiel requested review from neighbors-dev-bot and a team as code owners October 11, 2024 06:40
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 16, 2024
@kyma-bot kyma-bot merged commit 5e3fb3e into kyma-project:main Oct 16, 2024
75 checks passed
@dekiel dekiel deleted the fix-image-syncer branch October 16, 2024 16:02
@Sawthis Sawthis assigned dekiel and unassigned szumejker Oct 21, 2024
KacperMalachowski pushed a commit to KacperMalachowski/test-infra that referenced this pull request Nov 6, 2024
@dekiel @KacperMalachowski
Read access token to use it in authentication. (kyma-project#12123)
1c5bfec 
* Read access token to use it in authentication.

* Extract building new authenticator to separate function. The authenticator passed to the sync function already contains key or token.

* formating

* Log finished important steps

* Add suite test file to have only one entry point in to tests.

* Added missing suite test file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szumejker szumejker szumejker approved these changes

@neighbors-dev-bot neighbors-dev-bot Awaiting requested review from neighbors-dev-bot neighbors-dev-bot is a code owner

@KacperMalachowski KacperMalachowski Awaiting requested review from KacperMalachowski KacperMalachowski is a code owner automatically assigned from kyma-project/prow

Assignees

@dekiel dekiel

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dekiel @kyma-bot @szumejker