Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert image digest to manifest digest, Switch to use digest.Hex inst… #12040

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

akiioto
Copy link
Contributor

@akiioto akiioto commented Oct 1, 2024

…ead of digest.String()

Description

Changes proposed in this pull request:

  • Revert image digest to manifest digest
  • Use SHA value, instead of combination of algorithm and SHA value
  • ...

Related issue(s)

@akiioto akiioto requested review from neighbors-dev-bot and a team as code owners October 1, 2024 14:39
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 1, 2024
@akiioto
Copy link
Contributor Author

akiioto commented Oct 1, 2024

Changes between the original commit

I583797@L9KY260L6L testinfra % git diff HEAD 1b20062 -- pkg/sign/notary.go

diff --git a/pkg/sign/notary.go b/pkg/sign/notary.go
index 4285d72a4..7057c7430 100644
--- a/pkg/sign/notary.go
+++ b/pkg/sign/notary.go
@@ -140,7 +140,7 @@ func (mw *ManifestWrapper) GetConfigSize() int64 {
 
 // GetConfigDigest returns the digest of the image config.
 func (mw *ManifestWrapper) GetConfigDigest() string {
-       return mw.manifest.Config.Digest.Hex
+       return mw.manifest.Config.Digest.String()
 }
 
 // PayloadBuilderInterface defines the method for constructing the signing payload.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 1, 2024
@kyma-bot kyma-bot merged commit 709bacb into kyma-project:main Oct 1, 2024
13 checks passed
@akiioto akiioto deleted the revert_wrong_sha branch October 1, 2024 21:17
KacperMalachowski pushed a commit to KacperMalachowski/test-infra that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants