Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EncodedTags param #11172

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Conversation

dekiel
Copy link
Contributor

@dekiel dekiel commented Jun 27, 2024

Description

Changes proposed in this pull request:

image-builder client always send Tags parameter as base64 encoded string. After switching an oci-image-builder pipeline to always expect Tags parameter as base64 encoded, the additional EncodedTags parameter wont be needed.

@dekiel dekiel added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2024
@dekiel dekiel requested review from neighbors-dev-bot and a team as code owners June 27, 2024 10:47
@dekiel dekiel requested review from akiioto and Sawthis June 27, 2024 10:47
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 27, 2024
@dekiel dekiel removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2024
@dekiel dekiel changed the title Remove encoded taga param Remove Encoded`t param Jun 27, 2024
@dekiel dekiel changed the title Remove Encoded`t param Remove EncodedTags param Jun 27, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 27, 2024
@kyma-bot kyma-bot merged commit 7f2de8c into kyma-project:main Jun 27, 2024
22 checks passed
@dekiel dekiel deleted the remove-EncodedTaga-param branch June 27, 2024 13:05
@Sawthis Sawthis assigned dekiel and unassigned Sawthis Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants