Removed scenario testing missing target repo prefix.

FIxed linter errors.
kyma-project · Sep 18, 2024 · c97cf4b · c97cf4b
1 parent 2e077dd
commit c97cf4b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 14 deletions.
diff --git a/cmd/image-syncer/util_test.go b/cmd/image-syncer/util_test.go
@@ -81,17 +81,10 @@ var _ = Describe("getTarget", func() {
 
 var _ = Describe("parseImagesFile", func() {
 	validYAML := `
-targetRepoPrefix: "external/prod/"
 images:
   - source: "cypress/included:9.5.0"
     target: "external/prod/cypress/included:latest"
 `
-	missingTargetRepoPrefixYAML := `
-images:
-  - source: "cypress/included:9.5.0"
-    target: "external/prod/cypress/included:latest"
-`
-
 	tests := []struct {
 		name        string
 		content     string
@@ -103,12 +96,6 @@ images:
 			content:   validYAML,
 			shouldErr: false,
 		},
-		{
-			name:        "missing targetRepoPrefix",
-			content:     missingTargetRepoPrefixYAML,
-			shouldErr:   true,
-			expectedErr: "targetRepoPrefix can not be empty",
-		},
 	}
 
 	for _, test := range tests {

diff --git a/pkg/image-url-helper/promote/externalsyncer.go b/pkg/image-url-helper/promote/externalsyncer.go
@@ -27,7 +27,7 @@ func PrintExternalSyncerYaml(images common.ComponentImageMap, targetContainerReg
 }
 
 // convertImageslist takes in a list of images, target repository & tag and creates a SyncDef structure that can be later marshalled and used by the image-syncer tool
-func convertImageslist(images common.ComponentImageMap, targetContainerRegistry, targetTag string) imagesyncer.SyncDef {
+func convertImageslist(images common.ComponentImageMap, targetTag string) imagesyncer.SyncDef {
 
 	imageNames := make([]string, 0)
 	for _, image := range images {