Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Whitelist metrics scraped by self-monitor #982

Merged
merged 3 commits into from
Apr 18, 2024
Merged

feat: Whitelist metrics scraped by self-monitor #982

merged 3 commits into from
Apr 18, 2024

Conversation

skhalash
Copy link
Collaborator

@skhalash skhalash commented Apr 18, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Optimize self-monitor memory consumption by whitelisting the exact metrics we are scraping there
  • This change tightly couples the alertrules and config pkgs, so they were merged into one

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@skhalash skhalash requested a review from a team as a code owner April 18, 2024 12:32
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Apr 18, 2024
@skhalash skhalash added kind/feature Categorizes issue or PR as related to a new feature. and removed cla: yes Indicates the PR's author has signed the CLA. labels Apr 18, 2024
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 18, 2024
@skhalash skhalash added area/metrics MetricPipeline area/logs LogPipeline area/traces TracePipeline labels Apr 18, 2024
@skhalash skhalash added this to the 1.14.0 milestone Apr 18, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 18, 2024
@hisarbalik hisarbalik self-assigned this Apr 18, 2024
@skhalash skhalash changed the title feat: Whitelist metrics scraped by self monitor feat: Whitelist metrics scraped by self-monitor Apr 18, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 18, 2024
@kyma-bot kyma-bot merged commit 7729fb5 into kyma-project:main Apr 18, 2024
29 checks passed
@skhalash skhalash deleted the whitelist-exact-self-monitor-metrics branch April 30, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hisarbalik hisarbalik hisarbalik approved these changes

Assignees

@hisarbalik hisarbalik

Labels
area/logs LogPipeline area/metrics MetricPipeline area/traces TracePipeline cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@skhalash @hisarbalik @kyma-bot