Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Remove Flake attempts #748

Merged
merged 1 commit into from
Jan 24, 2024
Merged

test: Remove Flake attempts #748

merged 1 commit into from
Jan 24, 2024

Conversation

rakesh-garimella
Copy link
Contributor

Please enter the commit message for your changes. Lines starting

Description

Changes proposed in this pull request (what was done and why):

  • Flake attempt can mask the actual error, so remove it.

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@rakesh-garimella
test: Remove Flake attempts
194bfd1 
 Please enter the commit message for your changes. Lines starting
@rakesh-garimella rakesh-garimella added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. area/logs LogPipeline labels Jan 24, 2024
@rakesh-garimella rakesh-garimella requested a review from a team as a code owner January 24, 2024 15:42
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 24, 2024
@kyma-bot kyma-bot merged commit d499b05 into kyma-project:main Jan 24, 2024
20 checks passed
@rakesh-garimella rakesh-garimella deleted the remove-flake-attempt-istio branch January 24, 2024 16:00
@a-thaler a-thaler added this to the 1.8.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhalash skhalash skhalash approved these changes

Assignees

@skhalash skhalash

Labels
area/logs LogPipeline cla: yes Indicates the PR's author has signed the CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rakesh-garimella @skhalash @a-thaler @kyma-bot