Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve testkit package structure #647

Merged
merged 14 commits into from
Jan 23, 2024

Conversation

skhalash
Copy link
Collaborator

@skhalash skhalash commented Dec 18, 2023

Description

Changes proposed in this pull request (what was done and why):

  • Move all helpers to create different kinds of Kubernetes resources to the k8s package
  • Consolidate package names no for telemetry generator mocks
  • Lift apiserverproxy to the testkit root
  • Rename otlp to otel since it the package functionality is not only limited to OTLP
  • Bump Gingo CLI

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2023
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 18, 2023
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 22, 2024
@skhalash skhalash changed the title chore: Improve testkit pkg names chore: Improve testkit package structure Jan 22, 2024
@skhalash skhalash marked this pull request as ready for review January 22, 2024 12:37
@skhalash skhalash requested a review from a team as a code owner January 22, 2024 12:37
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2024
@skhalash skhalash added the area/tests Writing/adding/Refactoring tests or checks label Jan 23, 2024
@skhalash skhalash added the kind/chore Categorizes issue or PR as related to a chore. label Jan 23, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 23, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 23, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 23, 2024
@kyma-bot kyma-bot merged commit 3e50041 into kyma-project:main Jan 23, 2024
21 of 22 checks passed
@a-thaler a-thaler added this to the 1.8.0 milestone Jan 24, 2024
@skhalash skhalash deleted the rename-testkit-pkgs branch April 30, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Writing/adding/Refactoring tests or checks cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants