Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Flaky self-monitoring conditions #1735

Merged
merged 15 commits into from
Jan 13, 2025
Merged

fix: Flaky self-monitoring conditions #1735

merged 15 commits into from
Jan 13, 2025

Conversation

skhalash
Copy link
Collaborator

@skhalash skhalash commented Jan 9, 2025 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Use aggregated alerts instead of aggregating them in Go code to fix the flakiness problem
  • Rewrite rule rendering unit tests to use the golden file approach
  • Restructure the e2e tests - healthy state produces no alerts anymore, so no metrics are increased. Instead check instrumentation in negative tests.

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@skhalash skhalash added area/logs LogPipeline area/metrics MetricPipeline area/traces TracePipeline labels Jan 9, 2025
@skhalash skhalash added this to the 1.32.0 milestone Jan 9, 2025
@skhalash skhalash requested a review from a team as a code owner January 9, 2025 14:18
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 9, 2025
@skhalash skhalash changed the title Fix flaky self-monitoring conditions fix: Flaky self-monitoring conditions Jan 9, 2025
@skhalash skhalash added the kind/bug Categorizes issue or PR as related to a bug. label Jan 9, 2025
@k15r k15r self-requested a review January 10, 2025 15:11
@skhalash skhalash enabled auto-merge (squash) January 13, 2025 08:43
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 13, 2025
@skhalash skhalash merged commit 4ac0a2b into kyma-project:main Jan 13, 2025
38 checks passed
@skhalash skhalash deleted the fix-flaky-self-monitoring-conds branch January 13, 2025 10:32
a-thaler added a commit that referenced this pull request Jan 13, 2025
@a-thaler
Merge branch 'sample-app' of https://github.com/kyma-project/telemetr…
dba9bf8 
…y-manager into sample-app

* 'sample-app' of https://github.com/kyma-project/telemetry-manager:
  fix: Flaky self-monitoring conditions (#1735)
TeodorSAP added a commit that referenced this pull request Jan 14, 2025
@TeodorSAP
Revert "fix: Flaky self-monitoring conditions (#1735)"
dc8fbc0 
This reverts commit 4ac0a2b.
@skhalash skhalash mentioned this pull request Jan 14, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k15r k15r k15r approved these changes

Assignees

@k15r k15r

Labels
area/logs LogPipeline area/metrics MetricPipeline area/traces TracePipeline cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
1.32.0
Development

Successfully merging this pull request may close these issues.
3 participants
@skhalash @k15r @kyma-bot