Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: False positive status reason by timing issues in alert rules #1713

Closed
wants to merge 2 commits into from
Closed

fix: False positive status reason by timing issues in alert rules #1713

wants to merge 2 commits into from

Conversation

hisarbalik
Copy link
Contributor

@hisarbalik hisarbalik commented Dec 27, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@hisarbalik hisarbalik requested a review from a team as a code owner December 27, 2024 17:16
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 27, 2024
@hisarbalik hisarbalik added kind/bug Categorizes issue or PR as related to a bug. area/tests Writing/adding/Refactoring tests or checks area/metrics MetricPipeline area/traces TracePipeline do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 27, 2024
@hisarbalik hisarbalik added this to the 1.31.0 milestone Dec 27, 2024
@hisarbalik hisarbalik changed the title fix: False positive GatewayNoDataDelivered MetricPipeline and TracePipeline status reason fix: False positive status reason by timing issues in alert rules Dec 27, 2024
@a-thaler a-thaler modified the milestones: 1.31.0, 1.32.0 Jan 7, 2025
@skhalash skhalash closed this Jan 9, 2025
@a-thaler a-thaler removed this from the 1.32.0 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@skhalash skhalash

Labels
area/metrics MetricPipeline area/tests Writing/adding/Refactoring tests or checks area/traces TracePipeline cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hisarbalik @skhalash @a-thaler @kyma-bot