Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove app-pods-secure scrape job #1575

Merged
merged 16 commits into from
Nov 7, 2024
Merged

feat: Remove app-pods-secure scrape job #1575

merged 16 commits into from
Nov 7, 2024

Conversation

shorim
Copy link
Contributor

@shorim shorim commented Oct 29, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Remove scape job app-pods-secure which was responsible for scraping annotated Pods that either have an Istio sidecar or have the "prometheus.io/scheme" annotation set to "https"
  • Refactor the functions responsible for generating configs for prometheus receiver
  • Adjust documentation
  • Adjust unit tests
  • Add an e2e test

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@shorim shorim added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/metrics MetricPipeline labels Oct 29, 2024
@shorim shorim added this to the 1.27.0 milestone Oct 29, 2024
@shorim shorim requested a review from a team as a code owner October 29, 2024 15:51
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2024
@a-thaler a-thaler modified the milestones: 1.27.0, 1.28.0 Nov 5, 2024
@shorim shorim requested a review from a team as a code owner November 5, 2024 23:21
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2024
NHingerl
NHingerl reviewed Nov 7, 2024
View reviewed changes
docs/user/04-metrics.md Outdated Show resolved Hide resolved
docs/user/04-metrics.md Outdated Show resolved Hide resolved
docs/user/04-metrics.md Outdated Show resolved Hide resolved
@shorim shorim removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2024
NHingerl
NHingerl previously approved these changes Nov 7, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 7, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 7, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 7, 2024
@skhalash skhalash enabled auto-merge (squash) November 7, 2024 15:14
@skhalash skhalash merged commit 33a8adc into kyma-project:main Nov 7, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHingerl NHingerl NHingerl approved these changes

@skhalash skhalash skhalash approved these changes

Assignees

@skhalash skhalash

@NHingerl NHingerl

Labels
area/metrics MetricPipeline cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.28.0
Development

Successfully merging this pull request may close these issues.
5 participants
@shorim @skhalash @NHingerl @a-thaler @kyma-bot