Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix flakiness in metrics e2e tests #1543

Merged
merged 13 commits into from
Oct 23, 2024
Merged

test: Fix flakiness in metrics e2e tests #1543

merged 13 commits into from
Oct 23, 2024

Conversation

shorim
Copy link
Contributor

@shorim shorim commented Oct 21, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • For volume metrics e2e test:
    • Wait for the pods mounting volumes to be in a running state before executing the checks
    • Double the timeout of waiting for the expected volume metrics to be delivered
  • For pod metrics e2e test, triple the timeout for checking the expected resource attributes
  • Refactor the PodsReady function in the assert pkg to use Eventually inside it.

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@shorim shorim added kind/flaky-test Categorizes issue or PR as related to a flaky test. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/metrics MetricPipeline labels Oct 21, 2024
@shorim shorim added this to the 1.27.0 milestone Oct 21, 2024
@shorim shorim requested a review from a team as a code owner October 21, 2024 12:55
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Oct 21, 2024
@shorim shorim changed the title tests: Debug flaky metrics e2e tests test: Debug flaky metrics e2e tests Oct 21, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 22, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 22, 2024
@shorim shorim changed the title test: Debug flaky metrics e2e tests test: Fix flakiness in metrics e2e tests Oct 22, 2024
@shorim shorim removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 23, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 23, 2024
@kyma-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@shorim shorim merged commit c0c174d into kyma-project:main Oct 23, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k15r k15r k15r approved these changes

Assignees

@k15r k15r

Labels
area/metrics MetricPipeline cla: yes Indicates the PR's author has signed the CLA. kind/flaky-test Categorizes issue or PR as related to a flaky test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shorim @kyma-bot @k15r